Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force use of portable blst in Nim bindings #335

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Force use of portable blst in Nim bindings #335

merged 1 commit into from
Aug 11, 2023

Conversation

jtraglia
Copy link
Member

  • Ignore build directory that nimble test creates.
  • If not using an external blst, pass flag to compiler to build portable version of blst.

@jtraglia jtraglia requested a review from jangko August 11, 2023 13:10
asn-d6
asn-d6 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asn-d6 asn-d6 merged commit e76a7c0 into ethereum:main Aug 11, 2023
@jtraglia jtraglia deleted the nim-portable-blst branch August 11, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn-d6 asn-d6 asn-d6 approved these changes

@jangko jangko Awaiting requested review from jangko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @asn-d6