python: check file pointer when loading trusted setup (#401)

Co-authored-by: George Kadianakis <[email protected]>
ethereum · Mar 4, 2024 · 2ab0c21 · 2ab0c21
1 parent 486b15b
commit 2ab0c21
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/bindings/python/ckzg.c b/bindings/python/ckzg.c
@@ -10,15 +10,24 @@ static void free_KZGSettings(PyObject *c) {
 
 static PyObject* load_trusted_setup_wrap(PyObject *self, PyObject *args) {
   PyObject *f;
+  FILE *fp;
 
   if (!PyArg_ParseTuple(args, "U", &f))
     return PyErr_Format(PyExc_ValueError, "expected a string");
 
   KZGSettings *s = (KZGSettings*)malloc(sizeof(KZGSettings));
-
   if (s == NULL) return PyErr_NoMemory();
 
-  if (load_trusted_setup_file(s, fopen(PyUnicode_AsUTF8(f), "r")) != C_KZG_OK) {
+  fp = fopen(PyUnicode_AsUTF8(f), "r");
+  if (fp == NULL) {
+    free(s);
+    return PyErr_Format(PyExc_RuntimeError, "error reading trusted setup");
+  }
+
+  C_KZG_RET ret = load_trusted_setup_file(s, fp);
+  fclose(fp);
+
+  if (ret != C_KZG_OK) {
     free(s);
     return PyErr_Format(PyExc_RuntimeError, "error loading trusted setup");
   }