Add block_gossip SSE event #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
previously approved these changes
Jan 29, 2024
rolfyone
reviewed
Jan 29, 2024
apis/eventstream/index.yaml
Outdated
| block_gossip: | ||
| description: The node has received a block (from P2P or API) that passes validation rules of the `beacon_block` topic | ||
| value: | | ||
| event: block |
There was a problem hiding this comment.
actually i think this name needs to be block_gossip
|
@dapplion just changelog now :) |
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Jan 29, 2025
**Motivation** See ethereum/beacon-APIs#405 and ethereum/beacon-APIs#349 for further details and rationale for why we want two different block events. **Description** Emit `block_gossip` SSE event when receiving a block through gossip or api that passes validation rules of the `beacon_block` topic. On the api the validation might be skipped if the block was produced locally or a different broadcast validation is requested by the client but by default it will use gossip validation rules. Closes #6470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #404 to differentiate two stages of block validity.
block: block imported on the fork-choiceon_blockhandlerblock_gossip: passes validation rules of thebeacon_blocktopicSee discussion and motivation in #349