Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-820: Fix accidental tag #7397

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Update EIP-820: Fix accidental tag #7397

merged 1 commit into from
Aug 20, 2023

Conversation

Pandapip1
Copy link
Member

The creative commons CC0 link, since it was contained in an HTML code block instead of a markdown one, was interpreted as an HTML tag instead of raw text.

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner July 25, 2023 15:51
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels Jul 25, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 25, 2023

File EIPS/eip-820.md

Requires 1 more reviewers from @axic, @gcolvin, @lightclient

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jul 25, 2023
Pandapip1 added a commit that referenced this pull request Jul 25, 2023
@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone Jul 25, 2023
@github-actions
Copy link

The commit a77306c (as a parent of 80fd4eb) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 25, 2023
@@ -331,7 +331,9 @@ The contract has the address above for every chain on which it is deployed.
<details>
<summary>Raw metadata of <code>./contracts/ERC820Registry.sol</code></summary>
<pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has an extra <pre> tag, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. L653/L657.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the <pre> tag is closed, but is it necessary?

The rendered HTML (at least on GitHub) already inserts a <pre> tag for fenced code blocks:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not be removing the <pre> tag, as it is an unrelated modification to a Final EIP

@SamWilsn SamWilsn merged commit 9d3ab2e into master Aug 20, 2023
@SamWilsn SamWilsn deleted the Pandapip1-patch-11 branch August 20, 2023 14:35
SamWilsn pushed a commit that referenced this pull request Aug 20, 2023
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
Update EIP-820: Fix accidental HTML tag
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
Update EIP-820: Fix accidental HTML tag
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
Update EIP-820: Fix accidental HTML tag
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
Update EIP-820: Fix accidental HTML tag
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
Update EIP-820: Fix accidental HTML tag
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-erc w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants