Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-210: Make it not crash my build system #7370

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

Pandapip1
Copy link
Member

Sorry Vitalik, but that's not actually valid markdown.

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner July 21, 2023 02:05
@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Jul 21, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 21, 2023

File EIPS/eip-210.md

Requires 1 more reviewers from @vbuterin

@eth-bot eth-bot added the a-review Waiting on author to review label Jul 21, 2023
@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone Jul 21, 2023
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you only fix line 36 and not 32?

@SamWilsn SamWilsn merged commit 3cf49e6 into master Jul 24, 2023
@SamWilsn SamWilsn deleted the Pandapip1-patch-13 branch July 24, 2023 16:41
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
* Update EIP-210: Make it not crash my build system

* Missed one
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
* Update EIP-210: Make it not crash my build system

* Missed one
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
* Update EIP-210: Make it not crash my build system

* Missed one
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
* Update EIP-210: Make it not crash my build system

* Missed one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants