Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-3085: Move to Review #6457

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Update EIP-3085: Move to Review #6457

merged 5 commits into from
Sep 18, 2023

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Feb 7, 2023 •
edited by github-actions bot
Loading

Needs approval from either Erik Marks (@rekmarks) or Pedro Gomes (@pedrouid)

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-interface labels Feb 7, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 7, 2023 •
edited
Loading

✅ All reviewers have approved.

@Pandapip1 Pandapip1 marked this pull request as ready for review February 7, 2023 22:59
@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner February 7, 2023 22:59
@Pandapip1 Pandapip1 added the a-review Waiting on author to review label Feb 8, 2023
@Pandapip1
Copy link
Member Author

@eth-bot rerun

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 9, 2023
@Pandapip1
Copy link
Member Author

CC Erik Marks (@rekmarks) or Pedro Gomes (@pedrouid)

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 3, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label Jul 15, 2023
@eth-bot eth-bot changed the title Update EIP-3085: Add myself as an author and move back to Review Update EIP-3085: Move to Review Jul 22, 2023
@github-actions
Copy link

The commit fb4e78c (as a parent of cdbf5e4) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 22, 2023
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Aug 6, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 22, 2023
pedrouid
pedrouid approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@pedrouid pedrouid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eth-bot eth-bot enabled auto-merge (squash) September 15, 2023 04:51
eth-bot
eth-bot approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 16, 2023
@SamWilsn SamWilsn disabled auto-merge September 18, 2023 15:48
@SamWilsn SamWilsn merged commit 9c499a5 into master Sep 18, 2023
@SamWilsn SamWilsn deleted the Pandapip1-eip-3085-review branch September 18, 2023 15:48
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
@Pandapip1
Update EIP-3085: Move to Review (ethereum#6457)
9fc87f4 
* Update EIP-3085: Add myself as an author and move back to Review

* Update to fit latest EIP-1

* Update formatting to be similar to that of 2255

* Update eip-3085.md
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@Pandapip1 @RaphaelHardFork
Update EIP-3085: Move to Review (ethereum#6457)
6a64033 
* Update EIP-3085: Add myself as an author and move back to Review

* Update to fit latest EIP-1

* Update formatting to be similar to that of 2255

* Update eip-3085.md
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
@Pandapip1 @just-a-node
Update EIP-3085: Move to Review (ethereum#6457)
a6c691d 
* Update EIP-3085: Add myself as an author and move back to Review

* Update to fit latest EIP-1

* Update formatting to be similar to that of 2255

* Update eip-3085.md
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@Pandapip1 @GAEAlimited
Update EIP-3085: Move to Review (ethereum#6457)
824eff4 
* Update EIP-3085: Add myself as an author and move back to Review

* Update to fit latest EIP-1

* Update formatting to be similar to that of 2255

* Update eip-3085.md
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
@Pandapip1 @blacksnow2
Update EIP-3085: Move to Review (ethereum#6457)
2da01da 
* Update EIP-3085: Add myself as an author and move back to Review

* Update to fit latest EIP-1

* Update formatting to be similar to that of 2255

* Update eip-3085.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@pedrouid pedrouid pedrouid approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-review This EIP is in Review t-interface w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pandapip1 @eth-bot @pedrouid @SamWilsn