Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4361: Move to Review #6449

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Update EIP-4361: Move to Review #6449

merged 5 commits into from
Feb 21, 2023

Conversation

obstropolos
Copy link
Contributor

Update EIP-4361 back to Review from Stagnant.

@obstropolos obstropolos requested a review from eth-bot as a code owner February 6, 2023 03:28
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Feb 6, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 6, 2023

All reviewers have approved. Auto merging...

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 6, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably run into stability problems if you depend/link to so many EIPs, meaning you won't be able to advance your EIP's status past theirs. For example EIP-634 is Stagnant, so if you link to it, you'll be stuck in Draft. You can either remove these links or help those authors push their EIPs forward.

@Pandapip1 Pandapip1 changed the title Update EIP-4361 from Stagnant to Review Update EIP-4361: Move to Review Feb 8, 2023
@github-actions
Copy link

The commit 6e68c82 (as a parent of c65b83c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 12, 2023
@obstropolos
Copy link
Contributor Author

Alrighty I think I finally fixed all the issues! Praise be the linter and EIP Walidator.

@Pandapip1 / @SamWilsn

@obstropolos obstropolos requested review from SamWilsn and Pandapip1 and removed request for SamWilsn February 14, 2023 16:06
@eth-bot eth-bot enabled auto-merge (squash) February 21, 2023 15:07
@eth-bot eth-bot merged commit 10609ba into ethereum:master Feb 21, 2023
fulldecent pushed a commit to fulldecent/EIPs that referenced this pull request Mar 13, 2023
* Update EIP-4361 from Stagnant to Review

* Update eip-4361.md

* Update header spacing - EIP reliance - and fix markdown linter errors

* Update section spacing and updates to rename EIPs to ERCs when required to make linter less angry

* Update 1328 to ERC status and fix additional line spacing and headers

---------

Co-authored-by: Sam Wilson <[email protected]>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
* Update EIP-4361 from Stagnant to Review

* Update eip-4361.md

* Update header spacing - EIP reliance - and fix markdown linter errors

* Update section spacing and updates to rename EIPs to ERCs when required to make linter less angry

* Update 1328 to ERC status and fix additional line spacing and headers

---------

Co-authored-by: Sam Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants