Propose Emotable Extension for Non-Fungible Tokens #6381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed an interface for Non-Fungible Tokens extension allowing for reacting to them using Unicode emojis.
github-actions
bot
added
c-new
|
The commit 85ea5f9 (as a parent of 31a064c) contains errors. |
All tests passed; auto-merging...(pass) eip-6381.md
(pass) assets/eip-6381/contracts/Emotable.sol
(pass) assets/eip-6381/contracts/IEmotable.sol
(pass) assets/eip-6381/contracts/mocks/ERC721EmotableMock.sol
(pass) assets/eip-6381/hardhat.config.ts
(pass) assets/eip-6381/package.json
(pass) assets/eip-6381/test/emotable.ts
|
The proposal number was assigned based on the PR number. If the editors desire to change the PR number, that can be easily arranged.
27 tasks
SamWilsn
reviewed
Feb 7, 2023
EIPS/eip-6381.md
Outdated
|
|
||
| ```solidity | ||
| /// @title EIP-6381 Emotable Extension for Non-Fungible Tokens | ||
| /// @dev See https://eips.ethereum.org/EIPS/eip-5773 |
EIPS/eip-6381.md
Outdated
|
|
||
| pragma solidity ^0.8.16; | ||
|
|
||
| interface IRMRKEmotable is IERC165 { |
There was a problem hiding this comment.
Dosen't match the interface in the reference.
Updates description of EIP Co-authored-by: Sam Wilson <[email protected]>
SamWilsn
approved these changes
Feb 7, 2023
eth-bot
approved these changes
Feb 7, 2023
iseriohn
pushed a commit
to iseriohn/EIP-NFT-Rights-Management
that referenced
this pull request
Feb 16, 2023
* Propose Emotable Extension for Non-Fungible Tokens Proposed an interface for Non-Fungible Tokens extension allowing for reacting to them using Unicode emojis. * Assign a proposal number The proposal number was assigned based on the PR number. If the editors desire to change the PR number, that can be easily arranged. * Add discussion URL * Fix link typo * Update EIPS/eip-6381.md Updates description of EIP Co-authored-by: Sam Wilson <[email protected]> * Addresses editor suggestions. --------- Co-authored-by: Steven Pineda <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This EIP draft proposal includes RMRK team's work on developing an NFT standard where an NFT can be reacted to using Unicode emojis.