Add EIP: Hashtag NFT Collective Royalty Treasury #6145

AshleyTuring · 2022-12-15T18:05:21Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-12-15T18:06:02Z

File `EIPS/eip-6145.md`

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

EIPS/eip-royalty-treasury-proposal.md

AshleyTuring · 2022-12-22T05:35:39Z

@Pandapip1 the file was renamed from - to _ are we saying it is correct now or should be reverted back to - naming convention? (Thank you for the help!)

AshleyTuring · 2022-12-29T09:07:09Z

Happy holiday, please can someone advise on what the next steps are with this PR? It seem ready to me are there any issues outstanding?

AshleyTuring · 2023-01-04T14:55:25Z

Pandapip1 > Ots ok

@Erik4569 @Pandapip1 @abcoathup

Hope you had a good start to 2023. Is there anything I can do to progress this? I do not see what issues are outstanding with the PR?

EIPS/eip-royalty-treasury-proposal.md

Co-authored-by: Pandapip1 <[email protected]>

AshleyTuring

@Erik4569 @Pandapip1 @abcoathup

Thanks for the help with this, I cannot see why I am getting a Walidator error with a relative link to the license.md? Any suggestions you might have would be much appreciated. THANK YOU

Error: error[markdown-rel-links]: non-relative link or image
--> EIPS/eip-6145.md
|
84 | Copyright and related rights waived via CC0.
|
Error: validation found errors :(

AshleyTuring · 2023-02-05T12:12:29Z

@Erik4569 @Pandapip1 @abcoathup

Would appreciate any suggestions here, looks like a bug with the
Walidator
tried ./ and ../ now path to /License.md

?

SamWilsn · 2023-02-07T15:52:19Z

Sorry about the confusion with the markdown line numbers. eipw incorrectly reports external link errors as coming from the last line in the file.

SamWilsn · 2023-02-07T15:52:35Z

EIPS/eip-6145.md

+---
+eip: 6145
+title: Hashtag NFT Collective Royalty Treasury
+description: A method to deposit and retrieve royalties from an Ethereum Address


Suggested change

description: A method to deposit and retrieve royalties from an Ethereum Address

description: A method to deposit and retrieve royalties from an Ethereum address

SamWilsn · 2023-02-07T15:53:40Z

EIPS/eip-6145.md

+
+## Abstract
+
+This standard allows social media networks, NFT marketplaces and other websites to deposit royalties associated with an Ethereum address. The Ethereum address may be associated with a human readable name (e.g. a hashtag), to pay-out royalties and retrieve royalty payment information. The standard is loosely coupled and generic to maximise the potential use cases.  Unlike other EIP proposals [EIP-2981](./eip-2718.md) or [EIP-4910](./eip-4910.md) which embody mechanisms for calculating royalties, this standard sets out the mechanism for depositing and paying out royalties. The goal is to increase the earning potential for creators rather than defining the business logic for royalty payments.


Unlike other EIP proposals EIP-2981 or EIP-4910 which embody mechanisms for calculating royalties, this standard sets out the mechanism for depositing and paying out royalties.

This bit should be in motivation, not abstract. The abstract should just be a terse technical summary.

SamWilsn · 2023-02-07T15:54:31Z

EIPS/eip-6145.md

+
+## Copyright
+
+Copyright and related rights waived via [CC0](/LICENSE.md).


Suggested change

Copyright and related rights waived via [CC0](/LICENSE.md).

Copyright and related rights waived via [CC0](../LICENSE.md).

SamWilsn · 2023-02-07T15:55:00Z

EIPS/eip-6145.md

+|   |                              | Unique    | 0x9a6Cba29cc0cA4f18990F32De15aae08819F4cD0 |
+|   |                              | Quartz    | 0x9a6Cba29cc0cA4f18990F32De15aae08819F4cD0 |
+
+Further implementation details may be found in the Livetree repository found at the livetreetech/LivetreeCollective github repo.


Please remove any external links. Yes, we count this as an external link ;)

SamWilsn · 2023-02-07T15:55:21Z

EIPS/eip-6145.md

+| 2 | GetHashtagNFTBalances _(view)_ | **Inputs** _address tokenAddress_ - An Ethereum address **Outputs** uint256 - Returns sum of the royalties for given Ethereum address | Facilitates querying an Ethereum address and returning the royalties associated to the Ethereum address. The method **MUST** be called with an Ethereum address. |
+| 3 | WithdrawFromTreasuryToAddress | **Inputs** _address tokenAddress_ - Address royalty was associated in the deposit _address receiver_ - Royalty payout Ethereum address _uint256 amount_ - Royalty amount to be withdrawn to the receiver **Outputs** none emits **Withdraw** event _Withdraw(senderAddr, receiver, amount, tokenAddr);_ | Withdraws the given amount of the royalty (blockchain native token) associated with the Ethereum address to the receiver. The receiver **MAY** be a wallet, smart contract or other Ethereum address.  The tokenAddress **MUST** be an address the sender has deposited associated tokenAddress. The implementation of this method **SHOULD** restrict the caller and amount of withdrawal through the use of a whitelist defined in DepositRoyalty.
+
+### HashtagNFTCollectiveResolver


If these headings are code snippets, you should put them in backticks:

Suggested change

### HashtagNFTCollectiveResolver

### `HashtagNFTCollectiveResolver`

SamWilsn · 2023-02-07T15:57:03Z

EIPS/eip-6145.md

+
+| # | Function | Input / Output | Description |
+|---|----------|----------------|-------------|
+| 1 | DepositRoyalty _(payable)_ | **Inputs** _address[] calldata tokenAddresses_ - Array of Ethereum addresses _uint256[] calldata tokenRoyalties_ - Matching array of royalty deposit amounts for each Ethereum Address  **Outputs** none  emits **Deposit** event _event Deposit(senderAddr, address[] tokenAddresses, uint256[] tokenRoyalties);_ | This method optimises the gas costs relating to the deposit of royalties for a number of different associated Ethereum addresses. It takes an array of tokenAddresses (Ethereum addresses) associated with an array of tokenRoyalties (Royalty amounts).  tokenAddresses array **MUST** be paired equally and **MUST** be in the same order as tokenRoyalties. The deposit payable amount sent to this function **MUST** be in the blockchain’s native token (for example: ETH, GLMR, MOVR, CELO, UNQ etc). The payable amount of the native token **MUST** equal the sum of all tokenRoyalties. A human readable name registered in the naming service **MAY** be associated with the Ethereum address(es) provided in tokenAddresses. The implementation of this method stores the sender address in a “whitelist” along with the quantity of the blockchain’s native token deposited which is in turn is used to permission the method WithdrawFromTreasuryToAddress. |


I see a couple "MUST"s in here. If you're setting out requirements, they have to go in the Specification section.

The Backwards Compatibility section should just be for describing breaking changes. For example, if you were extending EIP-721 NFTs into soulbound tokens, you'd note here that soulbound tokens can't be transferred (unlike regular 721 NFTs).

SamWilsn · 2023-02-07T15:58:14Z

EIPS/eip-6145.md

+## Specification
+
+The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.
+


Your standard isn't standardizing anything. The meat of your proposal should be here.

github-actions · 2023-04-21T00:17:05Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2023-05-13T00:16:29Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2023-06-11T16:51:58Z

The commit e8db0b0 (as a parent of 4502e9b) contains errors.
Please inspect the Run Summary for details.

SamWilsn · 2023-06-26T16:48:13Z

@yamommasofat while I appreciate your plight, this is not the correct forum for discussing it. This repository contains technical standards for Ethereum developers. You might have better luck on /r/ethereum or attending an AllCoreDevs call to voice your concerns.

I also ask that you keep the discussion here civil.

github-actions · 2023-07-11T00:20:21Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2023-08-23T00:15:51Z

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

AshleyTuring · 2023-08-23T00:39:46Z

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

There has been no meaningful feedback on the PR - can someone from the Ethereum foundation please comment or let me know why it wasn't approved? I only see some bizarre cartoon pictures that seem unrelated

AshleyTuring added 3 commits December 15, 2022 17:52

livetree-ashley-turing-royalty-treasury-eip-proposal

0b16c5d

Update author

0f67dba

rename inline with EIP PR requirements

11a884c

AshleyTuring requested a review from eth-bot as a code owner December 15, 2022 18:05

fix header ---

1c08caf

github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Dec 15, 2022

AshleyTuring added 6 commits December 15, 2022 18:45

add missing sections according EIP template

c40f2a8

further format rearranging

ce8bebd

fix relative paths

aa625c8

url relative paths to EIP fix

0083035

remove links to other EIPs

f0c154f

readd links to EIPs

605515e

Pandapip1 reviewed Dec 16, 2022

View reviewed changes

EIPS/eip-royalty-treasury-proposal.md Outdated Show resolved Hide resolved

Pandapip1 changed the title ~~EIP Proposal - #Hashtag NFT Collective Royalty Treasury~~ Add EIP-6145: Hashtag NFT Collective Royalty Treasury Dec 16, 2022

Pandapip1 reviewed Jan 6, 2023

View reviewed changes

EIPS/eip-royalty-treasury-proposal.md Outdated Show resolved Hide resolved

Update EIPS/eip-royalty-treasury-proposal.md

5f1d0f6

Co-authored-by: Pandapip1 <[email protected]>

github-actions bot removed the e-number Waiting on EIP Number assignment label Jan 10, 2023

AshleyTuring added 4 commits January 10, 2023 09:40

update eip number to 6145

1b69afb

Merge branch 'master' of https://github.com/livetreetech/EIPs

c8db453

fix github link

7e35c84

rename file to eip-6145

ca597c3

github-actions bot added the w-ci Waiting on CI to pass label Jan 10, 2023

fix line spacing

e2d5600

AshleyTuring commented Jan 10, 2023

View reviewed changes

AshleyTuring added 2 commits January 11, 2023 14:55

remove link to license

09c0c43

remove link

3f4fab3

github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jan 11, 2023

AshleyTuring added 3 commits January 13, 2023 12:28

tried ./ and ../ now path to /License.md have

ee2a6f9

Walidator error no message try remove trailing

cb7abba

remove trailing return

e8db0b0

poojaranjan mentioned this pull request Feb 7, 2023

EIP Editing Office Hour Meeting 11 ethcatherders/EIPIP#207

Closed

27 tasks

ethereum deleted a comment Feb 7, 2023

SamWilsn reviewed Feb 7, 2023

View reviewed changes

github-actions bot added the w-stale Waiting on activity label Apr 21, 2023

This comment was marked as off-topic.

Sign in to view

github-actions bot removed the w-stale Waiting on activity label Apr 26, 2023

github-actions bot added the w-stale Waiting on activity label May 13, 2023

github-actions bot removed the w-stale Waiting on activity label May 25, 2023

eth-bot changed the title ~~Add EIP-6145: Hashtag NFT Collective Royalty Treasury~~ Add EIP: Hashtag NFT Collective Royalty Treasury Jun 11, 2023

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jun 11, 2023

github-actions bot added the w-stale Waiting on activity label Jul 11, 2023

github-actions bot closed this Aug 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: Hashtag NFT Collective Royalty Treasury #6145

Add EIP: Hashtag NFT Collective Royalty Treasury #6145

AshleyTuring commented Dec 15, 2022

eth-bot commented Dec 15, 2022 •

edited

Loading

AshleyTuring commented Dec 22, 2022

AshleyTuring commented Dec 29, 2022

AshleyTuring commented Jan 4, 2023 •

edited

Loading

AshleyTuring left a comment

AshleyTuring commented Feb 5, 2023

SamWilsn commented Feb 7, 2023

SamWilsn Feb 7, 2023

SamWilsn Feb 7, 2023

SamWilsn Feb 7, 2023

SamWilsn Feb 7, 2023

SamWilsn Feb 7, 2023

SamWilsn Feb 7, 2023

SamWilsn Feb 7, 2023

github-actions bot commented Apr 21, 2023

This comment was marked as off-topic.

github-actions bot commented May 13, 2023

github-actions bot commented Jun 11, 2023

SamWilsn commented Jun 26, 2023

github-actions bot commented Jul 11, 2023

github-actions bot commented Aug 23, 2023

AshleyTuring commented Aug 23, 2023 •

edited

Loading

	description: A method to deposit and retrieve royalties from an Ethereum Address
	description: A method to deposit and retrieve royalties from an Ethereum address


		## Abstract

		This standard allows social media networks, NFT marketplaces and other websites to deposit royalties associated with an Ethereum address. The Ethereum address may be associated with a human readable name (e.g. a hashtag), to pay-out royalties and retrieve royalty payment information. The standard is loosely coupled and generic to maximise the potential use cases. Unlike other EIP proposals [EIP-2981](./eip-2718.md) or [EIP-4910](./eip-4910.md) which embody mechanisms for calculating royalties, this standard sets out the mechanism for depositing and paying out royalties. The goal is to increase the earning potential for creators rather than defining the business logic for royalty payments.


		## Copyright

		Copyright and related rights waived via [CC0](/LICENSE.md).

	### HashtagNFTCollectiveResolver
	### `HashtagNFTCollectiveResolver`

		## Specification

		The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

Add EIP: Hashtag NFT Collective Royalty Treasury #6145

Add EIP: Hashtag NFT Collective Royalty Treasury #6145

Conversation

AshleyTuring commented Dec 15, 2022

eth-bot commented Dec 15, 2022 • edited Loading

File EIPS/eip-6145.md

AshleyTuring commented Dec 22, 2022

AshleyTuring commented Dec 29, 2022

AshleyTuring commented Jan 4, 2023 • edited Loading

AshleyTuring left a comment

Choose a reason for hiding this comment

AshleyTuring commented Feb 5, 2023

SamWilsn commented Feb 7, 2023

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

SamWilsn Feb 7, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 21, 2023

This comment was marked as off-topic.

github-actions bot commented May 13, 2023

github-actions bot commented Jun 11, 2023

SamWilsn commented Jun 26, 2023

github-actions bot commented Jul 11, 2023

github-actions bot commented Aug 23, 2023

AshleyTuring commented Aug 23, 2023 • edited Loading

eth-bot commented Dec 15, 2022 •

edited

Loading

File `EIPS/eip-6145.md`

AshleyTuring commented Jan 4, 2023 •

edited

Loading

AshleyTuring commented Aug 23, 2023 •

edited

Loading