-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-725: Improvements #6103
Conversation
A critical exception has occurred: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the walidator errors
Just 1 CI Error, anyway to resolve it ? @SamWilsn @Pandapip1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (requires approval from one of @frozeman, @tyleryasaka)
What does this PR introduce?
On the standard:
Executed
event to use bytes4 instead of bytesexecute
function in ERC725XContractCreated
event to include abytes32 salt
assets