Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-6036: Subscribeable NFT Extension #6036

Closed
wants to merge 32 commits into from

Conversation

aboutmydreams
Copy link

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Nov 23, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-6036.md

classification
newEIPFile

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-informational labels Nov 23, 2022
@Pandapip1 Pandapip1 changed the title Subscribeable NFT protocol (Draft) Add EIP-6036: Subscribeable NFT protocol (Draft) Nov 23, 2022
@Pandapip1 Pandapip1 changed the title Add EIP-6036: Subscribeable NFT protocol (Draft) Add EIP-6036: Subscribeable NFT protocol Nov 23, 2022
EIPS/eip-6036.md Outdated
title: Subscribeable NFT Extension
description: 721sub is a subscribable nft protocol that allows users to enjoy their benefits for a certain period of time.
author: Diven (@aboutmydreams), Kaso (@kasoqian), Jason (@350306878)
discussions-to: https://github.com/ethereum/EIPs/pull/6036
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a thread on FEM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

@Pandapip1 Pandapip1 changed the title Add EIP-6036: Subscribeable NFT protocol Add EIP-6036: Subscribeable NFT Extension Nov 23, 2022
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review. There are still other things that need fixing.

EIPS/eip-6036.md Outdated
}
```

`TokenIsExpire` means the expiration of a token, this is an event that should be thrown when the token expires.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you propose this is emitted?

@aboutmydreams
Copy link
Author

@Pandapip1 We have fixed the issues mentioned above. Thanks for checking again

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-informational w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants