Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5793: update EIP to Review status (eth/68) #6031

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Nov 22, 2022

This PR changes EIP-5793 (eth/68) to Review status, on request of @MariusVanDerWijden.

The EIP is a soft-dependency of EIP-4844 (the EIP will work without, but propagation of larger transactions is derisked with the functionality of this EIP) and ready to move to Review status.

@protolambda protolambda requested a review from eth-bot as a code owner November 22, 2022 19:28
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-networking labels Nov 22, 2022
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eth-bot
Copy link
Collaborator

eth-bot commented Nov 22, 2022

All reviewers have approved. Auto merging...

@protolambda protolambda changed the title EIP-5793: update EIP to Review status EIP-5793: update EIP to Review status (eth/68) Nov 22, 2022
@Pandapip1 Pandapip1 changed the title EIP-5793: update EIP to Review status (eth/68) Update EIP-5793: update EIP to Review status (eth/68) Nov 23, 2022
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@SamWilsn
Copy link
Contributor

Is there a PR moving EIP-4938 to Review? I think that's what's holding this one up.

@SamWilsn
Copy link
Contributor

SamWilsn commented Feb 8, 2023

@eth-bot rerun

@SamWilsn SamWilsn closed this Feb 8, 2023
@SamWilsn SamWilsn reopened this Feb 8, 2023
@SamWilsn SamWilsn closed this Feb 8, 2023
@SamWilsn SamWilsn reopened this Feb 8, 2023
@eth-bot eth-bot enabled auto-merge (squash) February 9, 2023 05:24
@eth-bot eth-bot merged commit 7ec13a7 into ethereum:master Feb 9, 2023
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants