Add EIP-5883: Token Transfer by Social Recovery #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All reviewers have approved. Auto merging... |
|
I couldn't see where an EIP editor assigned the EIP 5807? |
SamWilsn
reviewed
Nov 9, 2022
Dankyybomb1
previously approved these changes
Nov 9, 2022
Co-authored-by: Sam Wilson <[email protected]>
github-actions
bot
added
c-new
|
Does anybody know why the HTMLProofer fails, receiving this error That would be in the middle of the code snippet. |
Pandapip1
changed the title
|
We checked the markdown linter issues for now. The html proofer seems to be wrong. |
|
HTMLproofer is not wrong. Make sure that you escape any |
|
Should be fine now, thanks everyone! [@axic, @SamWilsn, @Pandapip1] |
xinbenlv
reviewed
Nov 19, 2022
|
When does the eth-bot review the PR? Is there something else to be done? [@axic, @SamWilsn, @Pandapip1, @eth-bot ] |
SamWilsn
reviewed
Nov 25, 2022
SamWilsn
reviewed
Nov 25, 2022
12 tasks
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
Ping - any chance to get this to Draft? Are we missing something? |
|
There's still a few outstanding comments. Most importantly about the Rationale section. |
|
Fixed, sorry overlooked them! |
wsdt
requested review from
SamWilsn,
xinbenlv and
Dankyybomb1
and removed request for
SamWilsn and
xinbenlv
27 tasks
|
anything missing? Would appreciate an update, thank you :-) |
Pandapip1
approved these changes
Feb 24, 2023
eth-bot
added
e-consensus
eth-bot
approved these changes
Feb 24, 2023
fulldecent
pushed a commit
to fulldecent/EIPs
that referenced
this pull request
Mar 13, 2023
* EIP - Social Recovery * delimiter * Social Recovery - Validation errors fix * Update EIPS/eip-5807.md Co-authored-by: Sam Wilson <[email protected]> * EIP 5883 - fixing validation errors * final validation errors fixed - EIP 5883 * Update eip-5883.md * Fix Markdown linter * Update eip-5883.md * Update eip-5883.md * Update eip-5883.md * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * applied feedback - 5883 * Fixing comments. --------- Co-authored-by: Sam Wilson <[email protected]>
axelcabee
pushed a commit
to axelcabee/EIPs
that referenced
this pull request
May 6, 2023
* EIP - Social Recovery * delimiter * Social Recovery - Validation errors fix * Update EIPS/eip-5807.md Co-authored-by: Sam Wilson <[email protected]> * EIP 5883 - fixing validation errors * final validation errors fixed - EIP 5883 * Update eip-5883.md * Fix Markdown linter * Update eip-5883.md * Update eip-5883.md * Update eip-5883.md * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * applied feedback - 5883 * Fixing comments. --------- Co-authored-by: Sam Wilson <[email protected]>
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
* EIP - Social Recovery * delimiter * Social Recovery - Validation errors fix * Update EIPS/eip-5807.md Co-authored-by: Sam Wilson <[email protected]> * EIP 5883 - fixing validation errors * final validation errors fixed - EIP 5883 * Update eip-5883.md * Fix Markdown linter * Update eip-5883.md * Update eip-5883.md * Update eip-5883.md * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5883.md Co-authored-by: Sam Wilson <[email protected]> * applied feedback - 5883 * Fixing comments. --------- Co-authored-by: Sam Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: Token Transfer by Social Recovery
description: This EIP describes a token recovery by a transfer from an identity which is not accessible anymore to another newly created identity by social interaction.
Looking forward to feedback!