Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Ganache private chains (5777) in EIP-155 #5877

Closed
wants to merge 1 commit into from

Conversation

rickmark
Copy link

@rickmark rickmark commented Nov 5, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@rickmark rickmark requested a review from eth-bot as a code owner November 5, 2022 01:46
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Nov 5, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 5, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-155.md

classification
updateEIP
  • eip-155.md is in state final at the head commit, not draft or last call or review; an EIP editor needs to approve this change
  • This PR requires review from one of [@lightclient, @axic, @gcolvin, @SamWilsn, @Pandapip1]
  • eip-155.md requires approval from one of (@vbuterin)

@rickmark
Copy link
Author

rickmark commented Nov 5, 2022

Not sure this is still valid, Ganache uses 1337/5777 which means the network id is common but not the same as the chain...

@@ -65,6 +65,7 @@ This would provide a way to send transactions that work on Ethereum without work
| 5 | Goerli |
| 42 | Kovan |
| 1337 | Geth private chains (default) |
| 5777 | Ganache GUI private chains (default) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale for this change is unclear. Why is this necessary? Does Gananche not already implement this?

@SamWilsn
Copy link
Contributor

We've discussed this change on today's EIPIP, and we will not be modifying EIP-155 to add this chain id.

EIPs are not the best place to maintain tables that are intended to change over time.

@SamWilsn SamWilsn closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-final This EIP is Final t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants