Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4906: Move Status to Final #5542

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Conversation

emojidao
Copy link
Contributor

EIP-4906: Move Status to Final

@emojidao emojidao requested a review from eth-bot as a code owner August 27, 2022 10:01
@github-actions github-actions bot added c-status Changes a proposal's status t-erc" labels Aug 27, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 27, 2022

A critical exception has occurred:
Message: pr 5542 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

0xanders
0xanders previously approved these changes Aug 27, 2022
@Pandapip1 Pandapip1 dismissed stale reviews from ghost and 0xanders via 605da41 August 28, 2022 00:27
@Pandapip1
Copy link
Member

@0xanders I made a few changes (typos + fixes + formatting errors). Could you make sure that the changes I've made are correct?

@Pandapip1 Pandapip1 changed the title EIP-4906: Move Status to Final Update EIP-4906: Move Status to Final Aug 28, 2022
@0xanders
Copy link
Contributor

@0xanders I made a few changes (typos + fixes + formatting errors). Could you make sure that the changes I've made are correct?

thank you!

@Pandapip1 Pandapip1 removed the t-erc" label Aug 28, 2022
@eth-bot eth-bot enabled auto-merge (squash) August 28, 2022 13:21
@eth-bot eth-bot merged commit b289dd1 into ethereum:master Aug 28, 2022
@emojidao emojidao deleted the 4906 branch October 25, 2022 02:22
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* EIP-4906: Update Status to Final

* Add some clarifications and some fixes

Co-authored-by: Anders <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
@pcaversaccio
Copy link
Contributor

Can someone quickly elaborate on how the interfaceId was exactly calculated here (since no functions are present within the interface)?

@Pandapip1
Copy link
Member

It was chosen arbitrarily IIUC.

@pcaversaccio
Copy link
Contributor

Ok thx @Pandapip1.

@holic
Copy link

holic commented Mar 6, 2023

Is _toTokenId inclusive?

And does this EIP apply to 1155s or just 721s?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants