Eip micropayments standard for nfts and multi tokens #4393

julesl23 · 2021-10-25T22:02:03Z

Hi,

Please find my new submission for an EIP. My email address is [email protected] if you wish to contact me via email.

Kind regards,
Jules Lai

…ulti Tokens

eth-bot · 2021-10-25T22:02:50Z

All tests passed; auto-merging...

(pass) EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

file EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md is not a valid filename, but this error has been ignored due to editor approvals

poojaranjan · 2021-10-29T13:48:35Z

Please add a one-line description of the EIP in the "description header" field and remove the "Simple Summary" section.
Add "Copyright"
"References" isn't a standard field.

EIP# will be provided by an EIP editor after review.

poojaranjan · 2021-10-29T17:16:20Z

@julesl23
A "New topic" can be created at Fellowship of Ethereum Magicians (FEM) to discuss this proposal and collect community feedback.
You may also add the FEM link to the "discussion to" section in the proposal.

julesl23 · 2021-10-29T18:32:57Z

@poojaranjan
Thanks, I added the FEM link to the proposal.

poojaranjan · 2021-10-29T18:59:32Z

@julesl23
Thanks for making the changes.
It will be reviewed by EIP editors and will be merged with the main repo if approved.

@alita-moore
I don't see any editor being pinged in this pull request. Can you check the bot for any possible bug?

alita-moore · 2021-10-29T19:39:16Z

@poojaranjan this is intended behavior when a file is not named correctly. What behavior would you prefer? Also please open a issue in eth-bot 😊

julesl23 · 2021-10-29T20:20:12Z

@poojaranjan this is intended behavior when a file is not named correctly. What behavior would you prefer? Also please open a issue in eth-bot 😊

@alita-moore
Opened an issue for the EIP file name problem. Not sure if I opened it correctly though

lightclient · 2021-10-30T04:15:04Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

@@ -0,0 +1,310 @@
+---
+eip: <to be assigned>


Suggested change

eip: <to be assigned>

eip: 4393

lightclient · 2021-10-30T04:15:19Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+eip: <to be assigned>
+title: Micropayments Standard for NFTs and Multi Tokens
+description: A standard interface for tip tokens that allows tipping to holders of NFTs and multi tokens
+author: Jules Lai (@julesl23), aka Julian Bushell


Suggested change

author: Jules Lai (@julesl23), aka Julian Bushell

author: Jules Lai (@julesl23)

Alternatively you can do Julian Bushell (@jules123). It is the author's choice what name they wish to go by.

lightclient · 2021-10-30T04:15:32Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+type: Standards Track
+category: ERC
+created: 2021-10-24
+requires: 721, 1155, 165


Suggested change

requires: 721, 1155, 165

requires: 165, 721, 1155

lightclient · 2021-10-30T04:16:07Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+
+## Abstract
+
+For the purpose of this proposal, a micropayment is termed as a financial transaction that involves usually a small sum of money, called "tips", that are sent for specific [ERC-721](https://eips.ethereum.org/EIPS/eip-721) NFTs and [ERC-1155](https://eips.ethereum.org/EIPS/eip-1155) multi tokens as rewards to their holders. A holder (also referred to as controller) is used here as a more generic term for owner in a semantic sense, as NFTs may represent non-digital assets, such as services etc.


Please use relative links of the form [EIP-X](./eip-X.md)

lightclient · 2021-10-30T04:16:26Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+
+For the purpose of this proposal, a micropayment is termed as a financial transaction that involves usually a small sum of money, called "tips", that are sent for specific [ERC-721](https://eips.ethereum.org/EIPS/eip-721) NFTs and [ERC-1155](https://eips.ethereum.org/EIPS/eip-1155) multi tokens as rewards to their holders. A holder (also referred to as controller) is used here as a more generic term for owner in a semantic sense, as NFTs may represent non-digital assets, such as services etc.
+
+This standard proposal outlines a generalised way to allow tipping via implementation of an ITipToken interface. The interface is intentionally kept to a minimum in order to allow for maximum use cases.


Suggested change

This standard proposal outlines a generalised way to allow tipping via implementation of an ITipToken interface. The interface is intentionally kept to a minimum in order to allow for maximum use cases.

This standard proposal outlines a generalised way to allow tipping via implementation of an `ITipToken` interface. The interface is intentionally kept to a minimum in order to allow for maximum use cases.

lightclient · 2021-10-30T04:17:46Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+
+## Motivation
+
+A cheap way to send tips to any type of NFT or multi token. This can be achieved by gas optimising the tip token contract and sending the tips in batches using the tipBatch function from the interface.


Suggested change

A cheap way to send tips to any type of NFT or multi token. This can be achieved by gas optimising the tip token contract and sending the tips in batches using the tipBatch function from the interface.

A cheap way to send tips to any type of NFT or multi token. This can be achieved by gas optimising the tip token contract and sending the tips in batches using the `tipBatch` function from the interface.

Please wrap code text in backticks.

lightclient · 2021-10-30T04:18:17Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+
+### Tip Token transfer and value calculations
+
+Tip token values are exchanged with ERC20 deposits and vice-versa. It is left to the tip token implementer to decide on the price of a tip token and hence how much tip to mint in exchange for the ERC20 deposited.


Suggested change

Tip token values are exchanged with ERC20 deposits and vice-versa. It is left to the tip token implementer to decide on the price of a tip token and hence how much tip to mint in exchange for the ERC20 deposited.

Tip token values are exchanged with ERC-20 deposits and vice-versa. It is left to the tip token implementer to decide on the price of a tip token and hence how much tip to mint in exchange for the ERC-20 deposited.

Please update all occurrences of unhyphenated ERC/EIPs.

lightclient · 2021-10-30T04:19:23Z

assets/eip-####/README.md

@@ -0,0 +1,2 @@
+EIP proposal "Micropayments Standard for NFTs and Multi Tokens" example implementation.


Please remove this file.

lightclient · 2021-10-30T04:19:42Z

assets/eip-####/README.md

@@ -0,0 +1,2 @@
+EIP proposal "Micropayments Standard for NFTs and Multi Tokens" example implementation.


Please remove this file.

axic · 2021-11-11T23:30:09Z

assets/eip-####/contracts/TipToken.sol

+/// @author Jules Lai
+/// @notice An implementation for a standard interface for tip tokens that allows tipping to holders of NFTs and multi tokens
+/// @dev Allows tipping for ERC-721 and ERC-1155 multi tokens. Their holders receive the rewards of ERC20 compatible deposits
+contract TipToken is ITipToken, ERC20, Ownable {


This is an implementation. Standards should not provide implementations, but interfaces.

This is an implementation. Standards should not provide implementations, but interfaces.

I removed the implementation and added in 'Reference Implementation' section of proposal a link to my public repo for example implementation and tests

MicahZoltu · 2021-11-13T11:35:13Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+## Reference Implementation
+
+A [reference/example implementation and tests](https://github.com/julesl23/eip_msnmt) in the GitHub repository that can use be used to assist in implementing this specification.
+


Suggested change

## Reference Implementation

A [reference/example implementation and tests](https://github.com/julesl23/eip_msnmt) in the GitHub repository that can use be used to assist in implementing this specification.

External links should not be included in EIPs. Either include an inline reference implementation, or files in ../assets/eip-4393/x.sol. Alternatively, this is an optional section and can simply be left out if that makes the most sense.

External links should not be included in EIPs. Either include an inline reference implementation, or files in ../assets/eip-4393/x.sol. Alternatively, this is an optional section and can simply be left out if that makes the most sense.

All sorted in the latest commit. Let me know if there is anything else I need to do.

@MicahZoltu

…xample implementation to help clarify Specification section in response to @MicahZoltu comment.

julesl23 · 2021-11-29T20:20:15Z

Hi, issue #4398 has been closed. Am I now waiting on editor approval for merge to move the PR to draft phase? Or is there anything else for me to do at this stage?

alita-moore · 2021-11-30T02:41:36Z

@julesl23 you'll need to assign the eip an eip number which will be provided by the editors

alita-moore · 2021-11-30T02:44:38Z

A critical exception has occurred (cc @alita-moore):
Message: not found

😑
I'm not near my computer for the next few days so I'll address this then.

MicahZoltu · 2021-12-01T04:28:33Z

Blocked by CI:

./EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md:105: everytime ==> every time
./EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md:218: idential ==> identical

Once that is resolved you'll need to wait for an editor to approve it (lightclient or axic most likely).

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

lightclient · 2021-12-06T04:18:21Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+
+## Specification
+
+The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.


Suggested change

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.

Implied via EIP-1

lightclient · 2021-12-06T04:19:04Z

EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

+
+The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.
+
+Smart contracts implementing the ERC-xxxx standard MUST implement all of the functions in the ERC-xxxx interface. MUST also emit the events specified in the interface so that a complete state of the tip token contract can be derived from the events emitted alone.


Need to replace EIP-xxxx -- usually prefer to not refer to the EIP itself by its own number. Instead say "this EIP" or a something similar.

…stract

julesl23 · 2021-12-15T21:00:06Z

Hi, please let me know if there is anything else before approval/review. Thanks

alita-moore · 2021-12-21T17:22:45Z

"pull request not in correct state to enable automerge" from enable-auto-merge

@lightclient

* New submission for EIP proposal Micropayments Standard for NFTs and Multi Tokens * Added github username to author * Corrected EIP md file name to eip-###.md * Tidied up; removed the ignore files * Made changes to conform to the eip-template.md * Added FEM link to the discussion-to section in the proposal * Made the changes suggested by @lightclient * Added support for shared holders of multi tokens * In assets folder, changed to include only .sol files * Added text to proposal to explain how tips help to create a level playing field * Removed implementation as requested by @axic * Removed optional Reference Implementation section and added snippet example implementation to help clarify Specification section in response to @MicahZoltu comment. * Corrected couple of typos as pointed out by @MicahZoltu * Made the changes requested by @lightclient, such as a more concise abstract

julesl23 added 2 commits October 25, 2021 22:29

New submission for EIP proposal Micropayments Standard for NFTs and M…

c94b0da

…ulti Tokens

Added github username to author

4fb5d01

eth-bot enabled auto-merge (squash) October 25, 2021 22:02

Corrected EIP md file name to eip-###.md

5048090

auto-merge was automatically disabled October 25, 2021 22:59
Head branch was pushed to by a user without write access

eth-bot enabled auto-merge (squash) October 25, 2021 23:00

Tidied up; removed the ignore files

447db23

auto-merge was automatically disabled October 27, 2021 01:14
Head branch was pushed to by a user without write access

eth-bot enabled auto-merge (squash) October 27, 2021 01:14

Made changes to conform to the eip-template.md

e1e82ed

auto-merge was automatically disabled October 29, 2021 17:10
Head branch was pushed to by a user without write access

eth-bot enabled auto-merge (squash) October 29, 2021 17:10

Added FEM link to the discussion-to section in the proposal

9bda1e6

auto-merge was automatically disabled October 29, 2021 18:25
Head branch was pushed to by a user without write access

eth-bot enabled auto-merge (squash) October 29, 2021 18:26

julesl23 mentioned this pull request Oct 29, 2021

@eth-bot gives EIP file name error problem for new submission #4398

Closed

lightclient reviewed Oct 30, 2021

View reviewed changes

lightclient requested changes Oct 30, 2021

View reviewed changes

Made the changes suggested by @lightclient

2542ac3

auto-merge was automatically disabled October 30, 2021 08:57
Head branch was pushed to by a user without write access

eth-bot enabled auto-merge (squash) October 30, 2021 08:57

Added support for shared holders of multi tokens

e796161

axic reviewed Nov 11, 2021

View reviewed changes

axic added the waiting: response from author label Nov 11, 2021

Removed implementation as requested by @axic

64ebe9b

MicahZoltu reviewed Nov 13, 2021

View reviewed changes

Removed optional Reference Implementation section and added snippet e…

463083e

…xample implementation to help clarify Specification section in response to @MicahZoltu comment.

alita-moore closed this Nov 22, 2021

alita-moore reopened this Nov 22, 2021

alita-moore closed this Nov 30, 2021

alita-moore reopened this Nov 30, 2021

alita-moore mentioned this pull request Nov 30, 2021

[bug] job fails critical exception no message (actually file format error) ethereum/EIP-Bot#30

Closed

ethereum deleted a comment Dec 1, 2021

Corrected couple of typos as pointed out by @MicahZoltu

132785b

lightclient requested changes Dec 6, 2021

View reviewed changes

Made the changes requested by @lightclient, such as a more concise ab…

647b6bc

…stract

MicahZoltu requested a review from lightclient December 19, 2021 01:52

lightclient approved these changes Dec 21, 2021

View reviewed changes

alita-moore closed this Dec 21, 2021

alita-moore reopened this Dec 21, 2021

eth-bot enabled auto-merge (squash) December 21, 2021 17:23

eth-bot merged commit 7c53a6b into ethereum:master Dec 21, 2021

eth-bot added ambiguous and removed waiting: response from author labels Dec 29, 2021

poojaranjan mentioned this pull request Dec 31, 2021

EIP merged but unavailable at eips.ethereum.org ethereum/EIP-Bot#40

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eip micropayments standard for nfts and multi tokens #4393

Eip micropayments standard for nfts and multi tokens #4393

julesl23 commented Oct 25, 2021

eth-bot commented Oct 25, 2021 •

edited

Loading

poojaranjan commented Oct 29, 2021

poojaranjan commented Oct 29, 2021

julesl23 commented Oct 29, 2021

poojaranjan commented Oct 29, 2021

alita-moore commented Oct 29, 2021

julesl23 commented Oct 29, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

MicahZoltu Dec 19, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

lightclient Oct 30, 2021

axic Nov 11, 2021

julesl23 Nov 12, 2021

MicahZoltu Nov 13, 2021

julesl23 Nov 23, 2021

julesl23 commented Nov 29, 2021

alita-moore commented Nov 30, 2021

alita-moore commented Nov 30, 2021

MicahZoltu commented Dec 1, 2021

lightclient Dec 6, 2021

julesl23 Dec 10, 2021

lightclient Dec 6, 2021

julesl23 Dec 10, 2021

julesl23 commented Dec 15, 2021

alita-moore commented Dec 21, 2021

	author: Jules Lai (@julesl23), aka Julian Bushell
	author: Jules Lai (@julesl23)


		## Abstract

		For the purpose of this proposal, a micropayment is termed as a financial transaction that involves usually a small sum of money, called "tips", that are sent for specific [ERC-721](https://eips.ethereum.org/EIPS/eip-721) NFTs and [ERC-1155](https://eips.ethereum.org/EIPS/eip-1155) multi tokens as rewards to their holders. A holder (also referred to as controller) is used here as a more generic term for owner in a semantic sense, as NFTs may represent non-digital assets, such as services etc.


		For the purpose of this proposal, a micropayment is termed as a financial transaction that involves usually a small sum of money, called "tips", that are sent for specific [ERC-721](https://eips.ethereum.org/EIPS/eip-721) NFTs and [ERC-1155](https://eips.ethereum.org/EIPS/eip-1155) multi tokens as rewards to their holders. A holder (also referred to as controller) is used here as a more generic term for owner in a semantic sense, as NFTs may represent non-digital assets, such as services etc.

		This standard proposal outlines a generalised way to allow tipping via implementation of an ITipToken interface. The interface is intentionally kept to a minimum in order to allow for maximum use cases.


		## Motivation

		A cheap way to send tips to any type of NFT or multi token. This can be achieved by gas optimising the tip token contract and sending the tips in batches using the tipBatch function from the interface.


		### Tip Token transfer and value calculations

		Tip token values are exchanged with ERC20 deposits and vice-versa. It is left to the tip token implementer to decide on the price of a tip token and hence how much tip to mint in exchange for the ERC20 deposited.

	Tip token values are exchanged with ERC20 deposits and vice-versa. It is left to the tip token implementer to decide on the price of a tip token and hence how much tip to mint in exchange for the ERC20 deposited.
	Tip token values are exchanged with ERC-20 deposits and vice-versa. It is left to the tip token implementer to decide on the price of a tip token and hence how much tip to mint in exchange for the ERC-20 deposited.

		@@ -0,0 +1,2 @@
		EIP proposal "Micropayments Standard for NFTs and Multi Tokens" example implementation.

		## Reference Implementation

		A [reference/example implementation and tests](https://github.com/julesl23/eip_msnmt) in the GitHub repository that can use be used to assist in implementing this specification.


		## Specification

		The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.


		The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.

		Smart contracts implementing the ERC-xxxx standard MUST implement all of the functions in the ERC-xxxx interface. MUST also emit the events specified in the interface so that a complete state of the tip token contract can be derived from the events emitted alone.

Eip micropayments standard for nfts and multi tokens #4393

Eip micropayments standard for nfts and multi tokens #4393

Conversation

julesl23 commented Oct 25, 2021

eth-bot commented Oct 25, 2021 • edited Loading

All tests passed; auto-merging...

(pass) EIPS/eip-micropayments_standard_for_nfts_and_multi_tokens.md

poojaranjan commented Oct 29, 2021

poojaranjan commented Oct 29, 2021

julesl23 commented Oct 29, 2021

poojaranjan commented Oct 29, 2021

alita-moore commented Oct 29, 2021

julesl23 commented Oct 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julesl23 commented Nov 29, 2021

alita-moore commented Nov 30, 2021

alita-moore commented Nov 30, 2021

MicahZoltu commented Dec 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julesl23 commented Dec 15, 2021

alita-moore commented Dec 21, 2021

eth-bot commented Oct 25, 2021 •

edited

Loading