1193: Fix example errata #3138
Merged
1193: Fix example errata #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MicahZoltu
reviewed
Nov 27, 2020
|
Since this is a non-normative change, it is reasonable for a PR against a |
Co-authored-by: Micah Zoltu <[email protected]>
|
@MicahZoltu sounds great, thanks for the suggestion |
rekmarks
approved these changes
Nov 27, 2020
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
This PR fixes two errata in the EIP-1193 examples section, special thanks to @enolan for noting in ethereum#2319 (comment) and ethereum#2319 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two errata in the EIP-1193 examples section, special thanks to @enolan for noting in #2319 (comment) and #2319 (comment).