Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-2384 - Difficulty Bomb Delay #2384

Merged
merged 7 commits into from
Nov 22, 2019
Merged

EIP-2384 - Difficulty Bomb Delay #2384

merged 7 commits into from
Nov 22, 2019

Conversation

econoar
Copy link
Contributor

@econoar econoar commented Nov 20, 2019 •
edited
Loading

Initial submission of EIP-2019 which would delay the difficulty bomb.

axic
axic reviewed Nov 20, 2019
View reviewed changes
@evertonfraga evertonfraga mentioned this pull request Nov 20, 2019
Closed
4 tasks
@econoar econoar changed the title EIP-2019 - Difficulty Bomb Delay EIP-2384 - Difficulty Bomb Delay Nov 20, 2019
axic
axic reviewed Nov 20, 2019
View reviewed changes
axic
axic reviewed Nov 20, 2019
View reviewed changes
axic
axic reviewed Nov 20, 2019
View reviewed changes
axic
axic reviewed Nov 20, 2019
View reviewed changes
@econoar
update eip-2384
a97193d 
Added better title, updated motivation with exact block numbers and date, fixed links and added a discussion link.
holiman
holiman reviewed Nov 21, 2019
View reviewed changes
This was referenced Nov 21, 2019
Merged
Merged
@econoar
update eip-2384.md
f51376a 
clarify language around block counts away from different forks
axic
axic reviewed Nov 21, 2019
View reviewed changes
@shemnon shemnon mentioned this pull request Nov 21, 2019
Merged
axic
axic reviewed Nov 22, 2019
View reviewed changes
@econoar
update eip-2384.md
fbe05c8 
spelling mistake and eth-mags discussion link
sassal
sassal reviewed Nov 22, 2019
View reviewed changes
@axic axic merged commit 1a627a7 into ethereum:master Nov 22, 2019
@tjayrush
Copy link

tjayrush commented Dec 2, 2019 •
edited
Loading

Why not choose a number that sets the fake_block number to a known quantity like 50,000 or 100,000? If we did that, the period would get set back to 0 or 1 and the amount of time between bomb diffusions would be maximized. Choosing 9,000,000 setback is arbitrary and depends on fork block which adds a bit of uncertainty that seems unnecessary. (It will set the period back to 1 most likely, though.)

The arbitrary choice of 5,000,000 for the previous bomb diffusion is, I think, why the bomb is appearing so early this time.

@axic
Copy link
Member

axic commented Dec 2, 2019

@tjayrush can you please leave this comment on the discussion URL?

@cyber-hokie cyber-hokie mentioned this pull request Dec 24, 2019
Merged
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@econoar @tkstanczak
EIP-2384 - Difficulty Bomb Delay (ethereum#2384)
7baf04c
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@econoar @Arachnid
EIP-2384 - Difficulty Bomb Delay (ethereum#2384)
7bd8644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman left review comments

@sassal sassal sassal left review comments

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@econoar @tjayrush @axic @holiman @sassal