EIP-1716 Hardfork Meta: Petersburg (a.k.a. "Constantinople Fix")

[5chdn]

eip: 1716
title: "Hardfork Meta: Petersburg"
author: Afri Schoedon (@5chdn)
type: Meta
status: Draft
created: 2019-01-21
requires: 1013, 1283

Abstract

This meta-EIP specifies the changes included in the Ethereum hardfork that removes EIP-1283 from Constantinople.

[5chdn]

also we need to merge #1689 and #1642 to finalized constantinople

[holiman]

Potential clarifications:

• If Petersburg and Constantinople are applied at the same block, Petersburg takes precedence: with the net effect of EIP 1283 being disabled.
• If Petersburg is defined with an earlier block number than Constantinople, then there is no immediate effect from the Petersburg fork. However, when Constantinople is later activated, EIP-1283 should be disabled.

[axic]

Isn't it easier to state Petersburg can only be applied after Constantinople, with the one exception of activating at the same time, then Petersburg takes preference?

[kvhnuke]

I agree with @axic It will better if we can set Petersburg block number >= Constantinople

[5chdn]

It makes it unnecessary complicated. The clarification Martin proposed clearly states how a client should behave if Petersburg < Constantinople.

[axic]

I beg to differ. With allowing Petersburg before Constantinople the client must track a flag, while my proposal would allow the client to just reject starting after parsing the block numbers in the configuration.

[holiman]

Well, the flag needs to be tracked regardless. With the proposed solution, we don't have to add an extra constraint when validating the configuration. It also makes it easier to manually/semi-manually create configurations, since you can set the petersburg block to 0 and don't worry about moving that one around if you move constantinople.
Also, geth has override.constantinople flag, which would continue to work nicely (and I'd recommend Parity to implement it too). If we change like you propose, the user would have to override both.

[chfast]

Wouldn't it be better to specify it that Petersburg activates EIP 145, 1014, 1052, 1234 and disables 1283?

[5chdn]

No, Constantinople enables EIP 145, 1014, 1052, 1234, and 1283; Petersfork disables 1283. I don't see why we should have two hardforks for the same thing.

[chfast]

Will that make the "Petersburg" its official name?

[axic]

@5chdn why did you close this? I think this one should be merged.