-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1013: Finalize all Constantinople hard-fork EIPs #1642
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2b2975b
eip-1013: finalize constantinople hard-fork meta
5chdn 42651d6
move all constantinople eips to final
5chdn 6244561
fix Constantinople block number
5chdn f3fa54d
Merge branch 'master' into patch-3
5chdn 251b4b8
Merge branch 'master' into patch-3
5chdn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ eip: 1052 | |
title: EXTCODEHASH opcode | ||
author: Nick Johnson <[email protected]>, Paweł Bylica <[email protected]> | ||
discussions-to: https://ethereum-magicians.org/t/extcodehash-opcode/262 | ||
status: Accepted | ||
status: Final | ||
type: Standards Track | ||
category: Core | ||
created: 2018-05-02 | ||
|
@@ -19,10 +19,10 @@ Contracts can presently do this using the `EXTCODECOPY` opcode, but this is expe | |
|
||
## Specification | ||
|
||
A new opcode, `EXTCODEHASH`, is introduced, with number 0x3F. The `EXTCODEHASH` | ||
takes one argument from the stack, zeros the first 96 bits | ||
and pushes to the stack the keccak256 hash of the code of the account | ||
at the address being the remaining 160 bits. | ||
A new opcode, `EXTCODEHASH`, is introduced, with number 0x3F. The `EXTCODEHASH` | ||
takes one argument from the stack, zeros the first 96 bits | ||
and pushes to the stack the keccak256 hash of the code of the account | ||
at the address being the remaining 160 bits. | ||
|
||
In case the account does not exist `0` is pushed to the stack. | ||
|
||
|
@@ -35,14 +35,14 @@ The gas cost of the `EXTCODEHASH` is 400. | |
|
||
## Rationale | ||
|
||
As described in the motivation section, this opcode is widely useful, and saves | ||
As described in the motivation section, this opcode is widely useful, and saves | ||
on wasted gas in many cases. | ||
|
||
The gas cost is the same as the gas cost for the `BALANCE` opcode because the | ||
The gas cost is the same as the gas cost for the `BALANCE` opcode because the | ||
execution of the `EXTCODEHASH` requires the same account lookup as in `BALANCE`. | ||
|
||
Only the 20 last bytes of the argument are significant (the first 12 bytes are | ||
ignored) similarly to the semantics of the `BALANCE`, `EXTCODESIZE` and | ||
Only the 20 last bytes of the argument are significant (the first 12 bytes are | ||
ignored) similarly to the semantics of the `BALANCE`, `EXTCODESIZE` and | ||
`EXTCODECOPY`. | ||
|
||
The `EXTCODEHASH` distincts accounts without code and non-existing accounts. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR should also mark all these included EIPs as
Final
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!