Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtl: fix replica tx indexing #872

Merged
merged 8 commits into from
May 14, 2021
Merged

dtl: fix replica tx indexing #872

merged 8 commits into from
May 14, 2021

Conversation

tynes
Copy link
Contributor

@tynes tynes commented May 13, 2021

Description
This PR adds in RLP serialization for when syncing from L2. This is required for matching state roots if syncing in replica mode

@tynes tynes requested a review from annieke as a code owner May 13, 2021 23:01
@changeset-bot
Copy link

changeset-bot bot commented May 13, 2021

🦋 Changeset detected

Latest commit: f4afa4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #872 (f4afa4a) into develop (0c16805) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #872   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c16805...f4afa4a. Read the comment docs.

@tynes tynes merged commit e28cec7 into develop May 14, 2021
@tynes tynes deleted the fix/replica-tx-indexing branch May 14, 2021 00:04
tynes added a commit that referenced this pull request May 14, 2021
* dtl: update constant to 9 million gaslimit

* dtl: parse as rlp without top level type

* chore: add changeset

* test: delete dead code

* lint: fix

* deps: add etherproject transactions

* dtl: better handler for more number types

* tests: fix chainid
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* dtl: update constant to 9 million gaslimit

* dtl: parse as rlp without top level type

* chore: add changeset

* test: delete dead code

* lint: fix

* deps: add etherproject transactions

* dtl: better handler for more number types

* tests: fix chainid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants