Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l2 geth: feat debug_ingestTransactions #853

Merged
merged 5 commits into from
May 19, 2021
Merged

l2 geth: feat debug_ingestTransactions #853

merged 5 commits into from
May 19, 2021

Conversation

tynes
Copy link
Contributor

@tynes tynes commented May 12, 2021

Description
Adds a new RPC endpoint debug_ingestTransactions which takes a list of transactions and then applies them to the state without any validation. This RPC must not be exposed to the internet because it is unsafe. It was added to the private debug namespace which also includes debug_setHead which can be used to reorganize the chain arbitrarily.

Additional context
This is useful for testing and generating state deterministically in geth

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2021

🦋 Changeset detected

Latest commit: f25fc70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tynes tynes changed the title Feat/ingest txs l2 geth: feat debug_ingestTransactions May 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #853 (fcc7c19) into develop (52d9e6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #853   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d9e6b...fcc7c19. Read the comment docs.

@tynes tynes force-pushed the feat/ingest-txs branch from fcc7c19 to 6c4e2ac Compare May 14, 2021 18:32
@gakonst gakonst merged commit 3958644 into develop May 19, 2021
@gakonst gakonst deleted the feat/ingest-txs branch May 19, 2021 07:33
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* l2geth: debug_ingestTransactions endpoint

* chore: add changeset

* l2geth: remove dead type

* chore: update changeset

Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants