feat: Add ChugSplash config parsing via Handlebars #739
Conversation
|
|
Good set of tests |
There was a problem hiding this comment.
Had a couple questions that I left on the PR but overall this looks suuuper dope! Great callout @tynes to use a templating library
| ).to.deep.equal({ | ||
| contracts: { | ||
| MyContract: { | ||
| address: `0x${'11'.repeat(20)}`, |
There was a problem hiding this comment.
Btw @smartcontracts real quick -- is address optional (at least when deploying to L1)? / What is it used for? I wrote in the doc that it was used for specifying the L2 address of contracts & I just want to verify that we are on the same page about that
There was a problem hiding this comment.
And if you leave it as optional chugsplash should CREATE2 calculate what the address will be & fill it in right?
There was a problem hiding this comment.
Yes, correct. Chugsplash will CREATE2 and fill it in for L1. Just not adding that logic yet since we'll want a whole suite of tests around making sure that's working correctly.
…#739) * feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
* feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
…#739) * feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
* feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
* feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
* feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
…#739) * feat: Add ChugSplash config parsing with handlebars * break out validation function * fix: minor typo in config tests
Description
Adds a simple helper function for parsing ChugSplash config files via https://handlebarsjs.com/.