test: ovm context #522
Merged
test: ovm context #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a02034d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
added
A-integration-tests
C-feature
snario
reviewed
Apr 20, 2021
snario
reviewed
Apr 20, 2021
Comment on lines
+124
to
+125
| // TODO: this is a bug and needs to be fixed | ||
| //expect(info.ethContext.blockNumber).to.deep.equal(blockNumber.toNumber()) |
There was a problem hiding this comment.
Is this bug documented in an issue?
There was a problem hiding this comment.
Documented here: #524
snario
approved these changes
Apr 21, 2021
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* integration tests: ovm context * integration tests: add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-adds tests that were left behind as part of the monorepo migration.
These tests specifically cover
NUMBERopcode which was fixed in ethereum-optimism/go-ethereum#280 as well as the returned values fromrollup_getInfo. This RPC endpoint returns the current rollup context as well as the OVM context. There is a bug that requires an assertion to be fixed, this PR could either be rebased on top of a fix or merged with a ticket to fix the problem in the future. If #477 doesn't fix the bug then it should be easy to do so after #477