l2geth: replica gas estimation fix #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc3c0a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
force-pushed
the
l2geth/replica-gas-estimation
branch
from
4249af4 to
fc3c0a6
Compare
|
Noticing #430 on this PR |
snario
approved these changes
Apr 21, 2021
|
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* l2geth: replica must also keep track of gas * l2geth: refactor sequencer loop * l2geth: updateL1GasPrice comment * l2geth: explicitly test gas updating * l2geth: add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a problem with the verifier/replica where it does not keep track of the current gas price. This is bad because it would make them not usable for
eth_estimateGas. Foreth_estimateGasto work, the node must know the current L1 gas price.It abstracts the update L1 gas price logic into its own function and then adds it to the verifier codepath so both the verifier and the sequencer keep track of the L1 gas price.
It builds off of:
SyncService.updateL1GasPricedirectlyRelated: