l2geth: rollup client batch api #516
Conversation
🦋 Changeset detectedLatest commit: cfa0dae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
force-pushed
the
l2geth/rollup-client-batch
branch
from
5a965a9 to
1cda714
Compare
| // Batch and its corresponding types.Transactions | ||
| func parseTransactionBatchResponse(txBatch *TransactionBatchResponse, signer *types.OVMSigner) (*Batch, []*types.Transaction, error) { | ||
| if txBatch == nil { | ||
| return nil, nil, nil |
There was a problem hiding this comment.
Should return an error here?
There was a problem hiding this comment.
Errors are currently not returned in the case where the element does not exist, but it is possible to do so. The consumer would have to do error comparison for the "element not found" case and then act appropriately. I opted to not do specific error checking client side and just return nil but now that I think about it, it feels like more idiomatic go to have a non-nil return value when the error is nil.
optimism/l2geth/rollup/sync_service.go
Lines 251 to 257 in c7bc0ce
There was a problem hiding this comment.
I've updated the error handling to use errors.Is for error comparison. This is the idiomatic way of doing things, see: https://golang.org/pkg/errors/
Below is from the docs
Is unwraps its first argument sequentially looking for an error that matches the second.
It reports whether it finds a match. It should be used in preference to simple equality checks:
if errors.Is(err, fs.ErrExist)is preferable to
if err == fs.ErrExist
tynes
force-pushed
the
l2geth/rollup-client-batch
branch
2 times, most recently
from
6e45f70 to
cfa0dae
Compare
* l2geth: add batch querying to rollup client * l2geth: add patch changeset * l2geth: complete mock client interface * l2geth: add comments to rollup client * l2geth: more idiomatic error handling
Description
Adds the batch fetching API to the
RollupClientso that it can be used to fetch batches from the DTL. Follow up PRs will use this code to sync as the verifier and also to ensure that the L2 transactions match what has been batch submitted as the sequencer.Additional context
This is required for #477