geth: only accept txs with a 0 value #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snario
approved these changes
Apr 13, 2021
|
Note that we may revert this after we support RLP transactions. |
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
mslipper
pushed a commit
that referenced
this pull request
May 15, 2022
contracts: add L1BlockNumber predeploy
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
…#435) - The key for Babylon in the config needs to be the FP key to be the signer - E2E testing now if the FP needs to sign something it needs to update the ClientController to be able to sign msgs with the corresponding key Related: babylonchain/babylon#678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until ethereum-optimism/contracts#300 is merged, we cannot accept transactions with an ETH value set. This PR prevents the sequencer from accepting transactions with a value set as well as adds an RPC level integration test for the functionality.