Change MIN_TX_SIZE to be in bytes #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynes
reviewed
Dec 11, 2020
| @@ -98,7 +98,7 @@ export class StateBatchSubmitter extends BatchSubmitter { | |||
| 'appendStateBatch', | |||
| [batch, startBlock] | |||
| ) | |||
| if (tx.length < this.minTxSize) { | |||
There was a problem hiding this comment.
I think that multiplying when setting this.minTxSize is safer, in case the variable ends up getting used elsewhere in the codebase
There was a problem hiding this comment.
Ah I like that! I'll change it -- one moment
|
Ideally this is fixed before mainnet |
|
@karlfloersch Was this applied to the batch submitter in the other repo? |
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
…napshot solidity: fail if updated gas snapshot isn't included
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
This PR addresses several typographical errors across various files in the project. The changes improve readability and maintain the professional standard of the documentation and code comments. Hope it helps Best regards, Elias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick bug fix where the state batch submitter was not using bytes for the MIN_TX_SIZE .
Contributing Agreement