Making revert messages flow through to the caller #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected]
- @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected]
masonforest
approved these changes
Mar 13, 2020
| let success := call( | ||
| gas, | ||
| codeAddress, | ||
| 0, | ||
| _callBytes, | ||
| callSize, | ||
| returnData, | ||
| 500000 |
- @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected] - @eth-optimism/[email protected]
gakonst
added a commit
that referenced
this pull request
Apr 12, 2021
* ci: disable yarn install cache * chore: use yarn test:ci to only test changes since master * ci: use separate job for linting contracts * feat(contracts): update to ethereum-optimism/contracts@06cdfb4 * feat(hardhat-ovm): replace env var with OVM config network ethereum-optimism/plugins#35 * feat(batch-submitter): update to ethereum-optimism/batch-submitter@8cd92d4 * feat(dtl): update to https://github.com/ethereum-optimism/data-transport-layer/commit/b1e340a32bd6986ba2c381a10229d49c0b274648 More unit tests and slight type refactoring * chore: regenerate yarn lock * fix(integration-tests): use `--network optimism` instead of env var * chore: yarn lint
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* deployment: script * deploy script: fix error message * scripts: fixes * deploy: update params * deploy: lower inclusion period
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* ci: disable yarn install cache * chore: use yarn test:ci to only test changes since master * ci: use separate job for linting contracts * feat(contracts): update to ethereum-optimism/contracts@06cdfb4 * feat(hardhat-ovm): replace env var with OVM config network ethereum-optimism/plugins#35 * feat(batch-submitter): update to ethereum-optimism/batch-submitter@8cd92d4 * feat(dtl): update to https://github.com/ethereum-optimism/data-transport-layer/commit/b1e340a32bd6986ba2c381a10229d49c0b274648 More unit tests and slight type refactoring * chore: regenerate yarn lock * fix(integration-tests): use `--network optimism` instead of env var * chore: yarn lint
Merged
teddyknox
pushed a commit
to teddyknox/optimism
that referenced
this pull request
Oct 3, 2023
SozinM
pushed a commit
to NethermindEth/optimism
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes revert messages flow through from the contract where the revert is called to the caller.
Metadata
Fixes
Contributing Agreement