Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxyd: Support per-RPC rate limits #3471

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Sep 14, 2022

Adds support for custom rate limits on a per-RPC method basis. We need this in order to limit abuse of expensive requests like eth_getLogs.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: b70ffcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/proxyd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mslipper mslipper requested a review from Inphi September 14, 2022 17:41
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/proxyd-per-rpc-lim branch from 695508c to 2bf9a5b Compare September 14, 2022 17:42
@mslipper mslipper requested a review from tynes September 14, 2022 17:43
@mslipper mslipper force-pushed the feat/proxyd-per-rpc-lim branch from 2bf9a5b to 14e4016 Compare September 14, 2022 17:46
@mslipper mslipper force-pushed the feat/proxyd-per-rpc-lim branch from 14e4016 to 43e6aad Compare September 14, 2022 17:52
@Inphi
Copy link
Contributor

Inphi commented Sep 15, 2022

excellent!

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 157ccc8 into develop Sep 15, 2022
@mergify mergify bot deleted the feat/proxyd-per-rpc-lim branch September 15, 2022 08:46
@mergify mergify bot removed the on-merge-train label Sep 15, 2022
This was referenced Sep 15, 2022
maurelian pushed a commit that referenced this pull request Sep 15, 2022
* proxyd: Support per-RPC rate limits

* add log

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* proxyd: Support per-RPC rate limits

* add log

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants