Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: use release instead of regenesis branches #2279

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

smartcontracts
Copy link
Contributor

Description
Changes our branching model to use release/ branches instead of
regenesis/ branches now that we no longer plan to perform any
regenesis-style upgrades. Using release/ branches will reduce confusion
from people who see a regenesis/ branch and assume (logically) that this
branch will result in a regenesis.

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2022

⚠️ No Changeset found

Latest commit: db0e585

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work labels Mar 7, 2022
@smartcontracts
Copy link
Contributor Author

Note: this is part of tech proposal #34 on slack.

Changes our branching model to use release/ branches instead of
regenesis/ branches now that we no longer plan to perform any
regenesis-style upgrades. Using release/ branches will reduce confusion
from people who see a regenesis/ branch and assume (logically) that this
branch will result in a regenesis.
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #2279 (db0e585) into develop (dfd5ac6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2279   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files           77       77           
  Lines         2460     2460           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         490      490           
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd5ac6...db0e585. Read the comment docs.

@smartcontracts smartcontracts force-pushed the sc/rename-regenesis-release branch from 29110ba to db0e585 Compare March 7, 2022 22:55
@mslipper mslipper merged commit 0f042da into develop Mar 8, 2022
@mslipper mslipper deleted the sc/rename-regenesis-release branch March 8, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-ci Meta: ci related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants