Two fixes 1) Fix getBlock - it never actually pulled in transactions 2) fix nil pointer possible deref #14188
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize 8414999 |
|
Thanks for the fixes @fxfactorial |
tynes
approved these changes
Feb 6, 2025
Merged
via the queue into
ethereum-optimism:develop
with commit Feb 6, 2025
6fdcb54
46 checks passed
alcueca
pushed a commit
that referenced
this pull request
Feb 7, 2025
…2) fix nil pointer possible deref (#14188) * Fix getBlock - it never actually pulled in transactions * exit with error if base fee is nil
alcueca
pushed a commit
that referenced
this pull request
Feb 7, 2025
…2) fix nil pointer possible deref (#14188) * Fix getBlock - it never actually pulled in transactions * exit with error if base fee is nil
alcueca
pushed a commit
that referenced
this pull request
Feb 7, 2025
…2) fix nil pointer possible deref (#14188) * Fix getBlock - it never actually pulled in transactions * exit with error if base fee is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to decode block body) and tried out the copy-payload command. But kept getting invalid new payload params from catalyst. Dug some more and found that there was no transactions in body.@protolambda while your embeded struct is elegant , the transactions field doesn't get unmarshaled because the embeded struct's unmarshal method becomes the method for the whole struct, so transactions get ignored.