Use castings according to padding #14174

alcueca · 2025-02-05T16:00:17Z

Description

Casting bytes20 -> bytes32 pads the variable on the right, while uint160 -> uint256 pads on the left.

In PR14134 a code simplification was introduced that calculated a salt in a non-conventional manner. While still correct, it might be confusing to future users.

This PR corrects that code simplification so that the salt is calculated in the regular manner (padding on the left with zeros).

…t160

Inphi

Nice! We just talked about this offline.

codecov · 2025-02-05T16:07:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.59%. Comparing base (31a9b25) to head (1fc1fdc).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #14174      +/-   ##
===========================================
- Coverage    45.90%   44.59%   -1.32%     
===========================================
  Files         1008      951      -57     
  Lines        86419    81747    -4672     
===========================================
- Hits         39673    36456    -3217     
+ Misses       43745    42474    -1271     
+ Partials      3001     2817     -184

Flag	Coverage Δ
cannon-go-tests-32	`?`
cannon-go-tests-64	`?`
contracts-bedrock-tests	`94.44% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol	`99.15% <100.00%> (ø)`
...racts-bedrock/src/L1/OPContractsManagerInterop.sol	`100.00% <100.00%> (ø)`

... and 62 files with indirect coverage changes

Inphi · 2025-02-05T16:07:28Z

Looks like the semver needs to be updated too. Though I believe there's a contracts freeze, so I dunno if this can be merged yet. cc: @maurelian

maurelian · 2025-02-05T16:24:50Z

Looks like the semver needs to be updated too. Though I believe there's a contracts freeze, so I dunno if this can be merged yet. cc: @maurelian

Good callout @Inphi. FYI:

the freeze is now enforced in CI (by check-frozen-files.sh).
We've lifted the freeze from the OPCM to allow for audit fixes and other polish.

… the L2 chain ID local key (#14300)

…unsafe head (#14206) * op-e2e: Introduce helpers for building transition states. * op-e2e: Add test for disputing a block prior to the proposal block * op-challenger: Handle requesting superchain roots beyond the current chain head. * Detect not found responses in prestate provider too. * Add test to confirm correct enforcement of trace extension activation. * Add more variants of tests where agreed = disputed. Cover all combinations of trace extension activating. * Remove printf

* Fix AddLink error type ; clean up reset logic * fix tests

Adds mirrored compiler restrictions to the lite profile so that all generated artifacts get overwritten when switching between build and build-dev.

This parallelizes the job with contracts-bedrock-build so that results are returned more quickly.

By wrapping the observed errors one layer too deep we were introducing escaped strings into the logs. Now multi-line and quoted strings appear as-is.

* op-program: Ensure exec msg inclusion during consolidation * implement timestamp invariants in the program * use msg expiry in rollup config * remove leftover non-working test

* feat: Ignore frozen files check by using a PR label * fix: following https://github.com/orgs/community/discussions/26712 * fix: maybe * fix: follow existing pattern * fix: temporarily remove the contracts changed check to make it run * spike: Using jq instead of grep * fix: don't extract labels twice * fix: a bit cleaner output * fix: minor change to trigger CI again * fix: Bring back the change check * feat: Docs * ci: use circleci-agent step halt to end job --------- Co-authored-by: alcueca <[email protected]> Co-authored-by: Maurelian <[email protected]> Co-authored-by: Maurelian <[email protected]>

…14266) * op-e2e: Add tests for cascading invalidations * Make InboxContract an entity in the DSL. * op-e2e: Focus test cases on consolidation. * op-e2e: Generate correct payload when executing messages. * op-e2e: Skip known failing test with reference to tracking issues.

* Add a new updatePrestatehash method to the OPContractsManager * deployed * second deployment * Go back to refactor * delete file * format * make diff smaller * even smaller * missing bracket * Go back on refactoring * fix build * fix build * fix build * fix build * fix versions * add snapshots * Add a new updatePrestatehash method to the OPContractsManager * deployed * second deployment * Go back to refactor * delete file * format * make diff smaller * even smaller * missing bracket * Go back on refactoring * fix build * fix build * fix build * fix build * fix versions * fix versions * add snapshots * update snapshots & semver * correct semver * bump OPCM version * move interface to inherit IOPCM * fix interface * update versions * add specs * fix deploy opcm setters * fix deploy opcm setters * changes asked on review & semver-lock * Add non implemented tests for coverage * linting * New tests & semverlock * rewrite hasFDG boolean * semver-lock * fix review comments * pre-pr * semver * semver-lock * semverlock again * final semverlock * fix comment about versions * fix comment about versions * semverlock opcm * feat: test upgrading just the pdg vs. both games * feat: remove unused assertValidGameType() function * review changes * remove unnecessary comment * update interface to fix CI * change file format * rebase * semver lock * valid semlock * rerun ci --------- Co-authored-by: JosepBove <[email protected]> Co-authored-by: JosepBove <[email protected]> Co-authored-by: JosepBove <[email protected]>

…at the same time.

alcueca added 2 commits February 5, 2025 15:53

fix: generate salt through uint, retrieve cahinId through bytes20+uin…

41ce283

…t160

fix: bytes20 is not necessary

b5195fe

alcueca requested a review from a team as a code owner February 5, 2025 16:00

alcueca requested a review from Inphi February 5, 2025 16:00

Inphi approved these changes Feb 5, 2025

View reviewed changes

alcueca added 3 commits February 7, 2025 10:53

fix: generated semver-lock.json

9102ddd

chore: lint

c19c3c4

fix: is this what you want?

1182463

alcueca requested review from a team as code owners February 7, 2025 13:30

alcueca requested review from bitwiseguy, refcell, mslipper, axelKingsley and protolambda February 7, 2025 13:30

alcueca force-pushed the bytes-pads-right branch from c3e2def to 1182463 Compare February 7, 2025 13:40

alcueca removed request for a team February 7, 2025 13:42

ajsutton and others added 22 commits February 12, 2025 06:59

op-program: Update test to ensure interop bootstrapping does not load…

d2a59a6

… the L2 chain ID local key (#14300)

op-conductor: Add new Raft flags into optional flags list (#14299)

875aea5

Update op-geth dependency to add uni-mainnet config (#14301)

95043fc

op-node: Define message expiry time constant (#14296)

c735e26

op-e2e: Fix fpp bls precompile tests (#14291)

fe8b68a

op-supervisor: Fix AddLink error type and clean up reset logic (#14302)

9e1991e

* Fix AddLink error type ; clean up reset logic * fix tests

feat(devnet-sdk): add helper to build execution environment (#14298)

ef4d681

fix: add mirrored restrictions to lite profile (#14295)

b2b1cbd

Adds mirrored compiler restrictions to the lite profile so that all generated artifacts get overwritten when switching between build and build-dev.

ci: make frozen files check depend on contracts-bedrock-build (#14316)

ab444a0

This parallelizes the job with contracts-bedrock-build so that results are returned more quickly.

fix(kurtosis-devnet): make logs more readable (#14317)

536cd6d

By wrapping the observed errors one layer too deep we were introducing escaped strings into the logs. Now multi-line and quoted strings appear as-is.

kt interop-devnet: enable super-cannon with interop-prestate (#14172)

78dbd5f

kt-devnet: switch to geth-teku for l1 (#14305)

84bb548

op-program: Ensure exec msg inclusion during consolidation (#14101)

d9e15b8

* op-program: Ensure exec msg inclusion during consolidation * implement timestamp invariants in the program * use msg expiry in rollup config * remove leftover non-working test

op-supervisor: Don't reset when node is far behind (#14324)

fc47cbf

op-supervisor: don't reet on all errors (#14326)

29faa1b

fix: generated semver-lock.json

d8114ee

chore: bumping version and semver-lock so that CI sees them changing …

0e6a3f3

…at the same time.

chore: bump semver-lock.json

178c1b5

alcueca added the M-exempt-frozen-files Meta: Exempt from frozen code label Feb 12, 2025

alcueca and others added 2 commits February 12, 2025 07:07

chore: bump versions and semver-lock

8a76985

Merge branch 'develop' into bytes-pads-right

1fc1fdc

alcueca enabled auto-merge February 12, 2025 07:21

alcueca added this pull request to the merge queue Feb 12, 2025

Merged via the queue into develop with commit 7ba4555 Feb 12, 2025
46 checks passed

alcueca deleted the bytes-pads-right branch February 12, 2025 07:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use castings according to padding #14174

Use castings according to padding #14174

alcueca commented Feb 5, 2025

Inphi left a comment

codecov bot commented Feb 5, 2025 •

edited

Loading

Inphi commented Feb 5, 2025

maurelian commented Feb 5, 2025

Use castings according to padding #14174

Use castings according to padding #14174

Conversation

alcueca commented Feb 5, 2025

Inphi left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 5, 2025 • edited Loading

Codecov Report

Inphi commented Feb 5, 2025

maurelian commented Feb 5, 2025

codecov bot commented Feb 5, 2025 •

edited

Loading