op-node,op-service: Add Timeout Flag for L2 Engine #13853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize d6b044a These are good changes, thank you! |
protolambda
changed the title
protolambda
changed the title
protolambda
approved these changes
Feb 4, 2025
Add a new --l2.engine-rpc-timeout flag to configure the timeout duration for L2 Engine RPC calls. This allows for more flexible and explicit control over RPC call timeouts.
protolambda
force-pushed
the
l2-engine-timeout
branch
from
d6b044a to
1bf4ef8
Compare
|
Rebased on latest |
|
/ci authorize 1bf4ef8 |
Merged
via the queue into
ethereum-optimism:develop
with commit Feb 4, 2025
3e9e692
46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the timeout duration for op-geth RPC calls from op-node to be adjusted via a flag.
During the implementation, it was discovered that a 5-second timeout is set in the engine_forkchoiceUpdatedV3 call, while the BaseRPCClient has a default 10-second timeout. These overlapping timeout settings have also been removed.
For more details: #13852
Tests
Additional context
Metadata