Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Add support for additional dispute games #13346

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mslipper
Copy link
Collaborator

Users can now specify additional dispute games with custom VM types and preimage oracles. This will help with removing allocs files in the future.

@mslipper mslipper requested a review from a team as a code owner December 10, 2024 22:33
Users can now specify additional dispute games with custom VM types and preimage oracles. This will help with removing allocs files in the future.
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.26%. Comparing base (eabf704) to head (0587acb).
Report is 7 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (eabf704) and HEAD (0587acb). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (eabf704) HEAD (0587acb)
2 1
cannon-go-tests-32 2 0
cannon-go-tests-64 2 0
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13346       +/-   ##
============================================
- Coverage    47.45%   26.26%   -21.20%     
============================================
  Files          931        7      -924     
  Lines        78188     1188    -77000     
  Branches       849        0      -849     
============================================
- Hits         37103      312    -36791     
+ Misses       38361      843    -37518     
+ Partials      2724       33     -2691     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 929 files with indirect coverage changes

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Making L2ChainID a common.Hash was a bit surprising but it fits with the required types of existing methods so ok. :)

@mslipper mslipper added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit 4d30eea Dec 11, 2024
42 checks passed
@mslipper mslipper deleted the feat/alt-proof-impls branch December 11, 2024 05:49
sigma pushed a commit that referenced this pull request Dec 19, 2024
Users can now specify additional dispute games with custom VM types and preimage oracles. This will help with removing allocs files in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants