Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Holocene Mainnet release #13334

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Prepare Holocene Mainnet release #13334

merged 1 commit into from
Dec 10, 2024

Conversation

sebastianst
Copy link
Member

No description provided.

@sebastianst sebastianst requested a review from geoknee December 10, 2024 18:19
@sebastianst sebastianst requested review from a team as code owners December 10, 2024 18:19
Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the superchain registry side of things. Looks like we need to cope with upstream op-geth changes before merging, so we should get another review on those changes when they are ready.

@sebastianst sebastianst requested a review from a team as a code owner December 10, 2024 18:51
@sebastianst sebastianst requested a review from ajsutton December 10, 2024 18:51
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.46%. Comparing base (eabf704) to head (f96f768).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13334      +/-   ##
===========================================
- Coverage    47.45%   44.46%   -2.99%     
===========================================
  Files          931      818     -113     
  Lines        78188    73092    -5096     
  Branches       849        0     -849     
===========================================
- Hits         37103    32504    -4599     
+ Misses       38361    37920     -441     
+ Partials      2724     2668      -56     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/superchain.go 0.00% <ø> (ø)

... and 132 files with indirect coverage changes

@protolambda
Copy link
Contributor

protolambda commented Dec 10, 2024

We're reverting the op-geth withdrawals-root change, to derisk the Holocene roll out. Do not merge this yet, until the chain config changes have been dropped, and until the op-geth dependency has been updated to include the merge of ethereum-optimism/op-geth#449

@protolambda protolambda added the M-do-not-merge Meta: Do not merge label Dec 10, 2024
@sebastianst sebastianst removed the M-do-not-merge Meta: Do not merge label Dec 10, 2024
@sebastianst sebastianst added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit 2f188a6 Dec 10, 2024
42 checks passed
@sebastianst sebastianst deleted the seb/holocene-mainnet branch December 10, 2024 19:26
sigma pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants