estimate gas correctly for blob tx in increaseGasPrice #13116
Merged
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
reviewed
Nov 27, 2024
|
@geoknee Any further advice for this PR? |
geoknee
approved these changes
Nov 29, 2024
|
/ci authorize 5df2ee6 |
|
/ci authorize 5df2ee6 |
|
@zhiqiangxu please rebase, a lot of the test errors here should be fixed. |
Done. |
|
/ci authorize a8bf388 |
Merged
via the queue into
ethereum-optimism:develop
with commit Dec 2, 2024
b6c28d5
46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes estimating gas work correctly for blob tx in
increaseGasPrice.It's similar to how it's done in
craftTxhere.(This PR can also be considered a left-over of this one.)