op-batcher: bound duration spent in state publishing loop #12909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
bound-state-publishing-duration
branch
from
4e579ce to
02f4a8a
Compare
geoknee
approved these changes
Nov 13, 2024
sebastianst
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
publishStateToL1 can block for a very long time if there is a large state backlog, preventing timely update of backlog metrics and the triggering of DA throttling. This PR lets the caller bound the time spent in the loop rather than allowing it to proceed until EOF is triggered.