Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opcm-redesign: opcm targets a single release #12851

Merged
merged 19 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: address didn't need to be payable.
  • Loading branch information
blmalone committed Nov 15, 2024
commit 748ba206d3588908611b3023fb0f50dac9f21133
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ contract DeployImplementationsOutput is BaseDeployIO {
require(_addr != address(0), "DeployImplementationsOutput: cannot set zero address");

// forgefmt: disable-start
if (_sel == this.opcm.selector) _opcm = OPContractsManager(payable(_addr)); // TODO: @blmalone does this need to be payable?
if (_sel == this.opcm.selector) _opcm = OPContractsManager(_addr);
else if (_sel == this.optimismPortalImpl.selector) _optimismPortalImpl = IOptimismPortal2(payable(_addr));
else if (_sel == this.delayedWETHImpl.selector) _delayedWETHImpl = IDelayedWETH(payable(_addr));
else if (_sel == this.preimageOracleSingleton.selector) _preimageOracleSingleton = IPreimageOracle(_addr);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ contract OPContractsManager_InternalMethods_Test is Test {
opcmHarness = new OPContractsManager_Harness({
_superchainConfig: superchainConfigProxy,
_protocolVersions: protocolVersionsProxy,
_l1ContractsReleaseVersion: "dev", // TODO: @blmalone update this to the correct value for this test.
_l1ContractsReleaseVersion: "dev",
_inputContracts: emptyInputContracts
});
}
Expand Down