-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-deployer: add 'inspect superchain-registry' subcommand #12736
Conversation
A couple of notes on this:
Given the above, there's no need to modify the pipeline, state, or intent code to fulfill the requirements of this ticket. All you have to do is define an inspect command that read the state/intent, and takes some CLI flags to populate the other env vars. |
I'm confused by this since there is this bullet item in the DoD for the ticket associated with this work. Can you help clarify?
|
5d3254d
to
d693d61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ptimism#12736) * op-deployer: add 'inspect superchain-registry' subcommand * op-deployer: generate artifacts at runtime of superchain-registry cmd * op-deployer: add missing err handler * op-deployer: add Printf to prompt user to populate .env vals * op-deployer: reformat addresses to superchain.AddressList
Closes #12612
Adds the following command to generate a .env file (written to
/<working-dir>/superchain-registry.env
:The .env output file can then be copied over to the superchain-registry and used for the
just add-chain
command.Tests
I manually tested that the
just add-chain
command runs without failure up until the point where it tries to start making contract calls, which it cannot complete since the contracts in the test are only deployed to a local env