-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding conduit bootnodes #12534
adding conduit bootnodes #12534
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12534 +/- ##
===========================================
- Coverage 65.04% 64.86% -0.18%
===========================================
Files 54 54
Lines 4460 4460
===========================================
- Hits 2901 2893 -8
- Misses 1382 1391 +9
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Semgrep found 5
require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 1 Prefer Semgrep found 11
Inputs to functions must be prepended with an underscore ( Semgrep found 1 No Semgrep found 1 Modifiers that don't do something before and after execution are banned. Ignore this finding from ban_non_wraparound_modifiers.Semgrep found 1 Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. Ignore this finding from no-direct-write-to-responsewriter.Semgrep found 1 Untrusted input could be used to tamper with a web page rendering, which can lead to a Cross-site scripting (XSS) vulnerability. XSS vulnerabilities occur when untrusted input executes malicious JavaScript code, leading to issues such as account compromise and sensitive information leakage. To prevent this vulnerability, validate the user input, perform contextual output encoding or sanitize the input. For more information, see: Go XSS prevention. View Dataflow Graphflowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>op-challenger/game/fault/trace/prestates/multi_test.go</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0["<a href=https://github.com/ethereum-optimism/optimism/blob/058d03f734fe5a44dd96ea0ffcc70bfa62430157/op-challenger/game/fault/trace/prestates/multi_test.go#L194 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 194] r.URL</a>"]
end
%% Intermediate
%% Sink
subgraph Sink
direction LR
v1["<a href=https://github.com/ethereum-optimism/optimism/blob/058d03f734fe5a44dd96ea0ffcc70bfa62430157/op-challenger/game/fault/trace/prestates/multi_test.go#L194 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 194] w.Write([]byte(r.URL.Path))</a>"]
end
end
%% Class Assignment
Source:::invis
Sink:::invis
File0:::invis
%% Connections
Source --> Sink
|
Description
In the
DefaultBootnodes
, we had two identical calls of:Tests
n/a
Additional context
A customer flagged this duplicate.