Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holocene: e2e test for Holocene's configurable eip-1559 params #12499

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

roberto-bayardo
Copy link
Collaborator

Description

Provides an E2E test that exercises the updating of the EIP-1559 parameters through SystemConfig contract, ensuring the base fee gets computed as expected both before and after the update.

@roberto-bayardo roberto-bayardo force-pushed the holocene-1559-e2e branch 2 times, most recently from 30886ac to c8fbf7f Compare October 17, 2024 01:46
@roberto-bayardo roberto-bayardo force-pushed the holocene-1559-e2e branch 4 times, most recently from 7af5be9 to 57ee64a Compare October 17, 2024 04:37
@roberto-bayardo roberto-bayardo force-pushed the holocene-sysconfig branch 4 times, most recently from f9c302f to 81935eb Compare October 21, 2024 22:10
Copy link
Contributor

semgrep-app bot commented Oct 21, 2024

Semgrep found 4 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

@roberto-bayardo roberto-bayardo force-pushed the holocene-sysconfig branch 2 times, most recently from 3b08777 to a1c2546 Compare October 21, 2024 23:16
@roberto-bayardo roberto-bayardo marked this pull request as ready for review October 21, 2024 23:17
@tynes tynes force-pushed the holocene-sysconfig branch from a1c2546 to eb6461c Compare October 22, 2024 05:12
Base automatically changed from holocene-sysconfig to develop October 22, 2024 05:36
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just two nits

@sebastianst sebastianst enabled auto-merge October 22, 2024 16:04
@roberto-bayardo roberto-bayardo force-pushed the holocene-1559-e2e branch 2 times, most recently from fb37d9e to 1095bc5 Compare October 22, 2024 17:07
@sebastianst sebastianst added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 90fb25f Oct 22, 2024
48 checks passed
@sebastianst sebastianst deleted the holocene-1559-e2e branch October 22, 2024 17:40
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants