cannon: Add more load / store tests #12432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12432 +/- ##
===========================================
- Coverage 64.48% 64.29% -0.19%
===========================================
Files 52 52
Lines 4361 4361
===========================================
- Hits 2812 2804 -8
- Misses 1373 1382 +9
+ Partials 176 175 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Inphi
approved these changes
Oct 11, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 11, 2024
9d9dc32
58 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* cannon: Add a few more load/store test cases * cannon: Add some more load test cases with negative numbers * cannon: Specify test names more precisely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some more differential test cases for load and store operations.
Metadata
Part of #12032