[batcher] Add Channel interface and factory #12337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
force-pushed
the
michael/channel-interface
branch
from
008d053 to
c262d85
Compare
|
Decided to implement this an alternative way, PR incoming |
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Channelinterface, and the ability to customize theChannelimplementation by passing in aChannelFactoryfunction to theDriverSetup/BatcherService.Tests
Added test for factory, and updated existing tests to work with new interface.
Additional context
The L3 project needs the ability to customize what happens on Block and Tx submission. This PR provides the required hooks.