Batcher: support the txmgr.TxManager interface rather than SimpleTxManager implementation #12040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12040 +/- ##
===========================================
- Coverage 79.10% 78.87% -0.24%
===========================================
Files 41 41
Lines 3437 3437
===========================================
- Hits 2719 2711 -8
- Misses 548 557 +9
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
mdehoog
force-pushed
the
michael/tx-manager-interface
branch
from
9056ba1 to
d8c775a
Compare
mdehoog
force-pushed
the
michael/tx-manager-interface
branch
from
d8c775a to
f418adf
Compare
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 22, 2024
de7f8d9
61 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the
*txmgr.SimpleTxManagerin the batcher driver setup with thetxmgr.TxManagerinterface. This allows more flexibility in the TxManager implementation.This was changed in #10941 for testing purposes; there's no particular reason the batcher needs the
SimpleTxManagerimplementation.Tests
Updated tests.
Additional context
I'm working on a separate batcher implementation for L3s that uses a different TxManager.