Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op-e2e): Recover from bad transactions in batch test #12039

Merged
merged 4 commits into from
Sep 22, 2024
Merged

feat(op-e2e): Recover from bad transactions in batch test #12039

merged 4 commits into from
Sep 22, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Sep 21, 2024

Overview

Adds a few tests for the op-program where batches are submitted that have bad transactions in them (bad signature), and then are re-submited.

@clabby clabby requested review from a team as code owners September 21, 2024 04:29
@semgrep-app semgrep-app
Copy link
Contributor

semgrep-app bot commented Sep 21, 2024

Semgrep found 7 golang_fmt_errorf_no_params findings:

  • op-chain-ops/deployer/state/intent.go
  • op-chain-ops/deployer/pipeline/superchain.go
  • op-chain-ops/deployer/pipeline/opchain.go
  • op-chain-ops/deployer/pipeline/l2genesis.go
  • op-chain-ops/deployer/pipeline/implementations.go
  • op-chain-ops/deployer/inspect/rollup.go
  • op-chain-ops/deployer/inspect/flags.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

@clabby clabby force-pushed the cl/invalid-tx-batch branch from 5df97af to ff5965a Compare September 21, 2024 05:20
@clabby clabby requested review from ajsutton and removed request for geoknee September 21, 2024 15:43
@clabby clabby force-pushed the cl/invalid-tx-batch branch from ff5965a to 68cf07f Compare September 21, 2024 15:47
@clabby clabby force-pushed the cl/invalid-tx-batch branch from 3a935df to 6928d6c Compare September 21, 2024 19:15
@clabby Graphite App
Copy link
Member Author

clabby commented Sep 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Sep 21, 2024
Merged
refcell
refcell approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on function naming but otherwise looks clean and nice inline comments

@clabby clabby enabled auto-merge September 22, 2024 01:50
@clabby clabby added this pull request to the merge queue Sep 22, 2024
Merged via the queue into develop with commit 53080c9 Sep 22, 2024
64 checks passed
@clabby clabby deleted the cl/invalid-tx-batch branch September 22, 2024 02:09
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@clabby @samlaf
feat(op-e2e): Recover from bad transactions in batch test (ethereum-o…
36dcec7 
…ptimism#12039)

* feat(op-e2e): Recover from bad transactions in batch test

* fix

* clean

* naming nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@pauldowman pauldowman Awaiting requested review from pauldowman pauldowman is a code owner automatically assigned from ethereum-optimism/proofs

@ajsutton ajsutton Awaiting requested review from ajsutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell