Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: delete unused eslint deps #11170

Merged
merged 1 commit into from
Jul 22, 2024
Merged

deps: delete unused eslint deps #11170

merged 1 commit into from
Jul 22, 2024

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jul 17, 2024

Description

Every dependency is a liability. We should strive to remove every
dependency that isn't critical. The JS stuff in the monorepo is
deprecated at this point but we still carry around a ton of deps
that should be removed asap from the repo.

This commit removes some unused eslint plugins, one small step towards
removing deps that are not necessary.

Every dependency is a liability. We should strive to remove every
dependency that isn't critical. The JS stuff in the monorepo is
deprecated at this point but we still carry around a ton of deps
that should be removed asap from the repo.

This commit removes some unused eslint plugins, one small step towards
removing deps that are not necessary.
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.69%. Comparing base (e00f23a) to head (4a3ac77).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #11170   +/-   ##
========================================
  Coverage    60.69%   60.69%           
========================================
  Files           20       20           
  Lines         1781     1781           
  Branches        71       71           
========================================
  Hits          1081     1081           
  Misses         667      667           
  Partials        33       33           
Flag Coverage Δ
cannon-go-tests 79.69% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tynes tynes enabled auto-merge July 17, 2024 18:15
@tynes tynes added this pull request to the merge queue Jul 22, 2024
Merged via the queue into develop with commit bc1db62 Jul 22, 2024
63 checks passed
@tynes tynes deleted the deps/rm-eslint branch July 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants