Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: support auto switch to cheaper DA type #11059

Closed
wants to merge 3 commits into from

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Jul 2, 2024

Description

This PR adds auto switch DA type feature to op-batcher.

When set --data-availability-type=auto, this feature is enabled. Batcher will start with blob-type, and keep monitoring the cost of blob-type and calldata-type, when another type is cheaper, batcher will switch to that type to save the cost.

L1 txpool ErrAlreadyReserved is handled as well to avoid stuck when switching(removed it in this pr due to another pr merged into develop)

Tests

Additional context

Metadata

@bnoieh bnoieh requested a review from a team as a code owner July 2, 2024 07:57
@bnoieh bnoieh requested a review from mbaxter July 2, 2024 07:57
@tynes
Copy link
Contributor

tynes commented Jul 4, 2024

This is a very useful feature, thank you for implementing it. For this to be merged, there will need to be test coverage added. I also believe it should be possible to implement in fewer lines of code.

@bnoieh
Copy link
Contributor Author

bnoieh commented Jul 9, 2024

This is a very useful feature, thank you for implementing it. For this to be merged, there will need to be test coverage added. I also believe it should be possible to implement in fewer lines of code.

sure. let me add tests and welcome any comments about the implement

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 24, 2024
@github-actions github-actions bot removed the Stale label Jul 25, 2024
@bnoieh
Copy link
Contributor Author

bnoieh commented Jul 25, 2024

@sebastianst i saw that there's another pr #11219 trying to implement the same feature, you can close this pr if the other one is preferred. If this pr is still needed, plz let me know and i'll add some test code

@sebastianst
Copy link
Member

@sebastianst i saw that there's another pr #11219 trying to implement the same feature, you can close this pr if the other one is preferred. If this pr is still needed, plz let me know and i'll add some test code

Hey @bnoieh thanks for this PR! It inspired the work in that other PR and I gave you credit in the description. I'm gonna close this one as redundant.

@sebastianst sebastianst closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants