-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove miner codepath #1077
Remove miner codepath #1077
Conversation
🦋 Changeset detectedLatest commit: 787f2ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1077 +/- ##
========================================
Coverage 82.26% 82.26%
========================================
Files 49 49
Lines 1900 1900
Branches 303 303
========================================
Hits 1563 1563
Misses 337 337 Continue to review full report at Codecov.
|
4b238d8
to
8cb6e17
Compare
8cb6e17
to
787f2ce
Compare
Going to close this PR. We haven't had any movement on it for a while and we're likely going to need to completely redo it against the experimental branch. |
SGTM. Apologies for not being able to get it over the line at the time. |
Supersedes #875.
Features:
reverts the miner back to geth 1.9.10 code, makes code panic on miner calls
introduces a new consensus engine which just passes blocks through
makes the sync service write transactions & receipts directly to the database
geth unit tests: fixed to provide enough gas & sign on transactions before submitting them
integration tests
being able to sync a replica (manually tested)
Fixes OP-285