Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove miner codepath #1077

Closed
wants to merge 11 commits into from
Closed

Remove miner codepath #1077

wants to merge 11 commits into from

Conversation

gakonst
Copy link
Contributor

@gakonst gakonst commented Jun 13, 2021

Supersedes #875.

Features:

  • reverts the miner back to geth 1.9.10 code, makes code panic on miner calls

  • introduces a new consensus engine which just passes blocks through

  • makes the sync service write transactions & receipts directly to the database

  • geth unit tests: fixed to provide enough gas & sign on transactions before submitting them

  • integration tests

  • being able to sync a replica (manually tested)

Fixes OP-285

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2021

🦋 Changeset detected

Latest commit: 787f2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #1077 (8cb6e17) into develop (6d7b12b) will not change coverage.
The diff coverage is n/a.

❗ Current head 8cb6e17 differs from pull request most recent head 787f2ce. Consider uploading reports for the commit 787f2ce to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1077   +/-   ##
========================================
  Coverage    82.26%   82.26%           
========================================
  Files           49       49           
  Lines         1900     1900           
  Branches       303      303           
========================================
  Hits          1563     1563           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7b12b...787f2ce. Read the comment docs.

@gakonst gakonst marked this pull request as draft June 13, 2021 14:42
@gakonst gakonst force-pushed the gakonst/remove-miner-2 branch from 4b238d8 to 8cb6e17 Compare June 14, 2021 07:17
@gakonst gakonst force-pushed the gakonst/remove-miner-2 branch from 8cb6e17 to 787f2ce Compare June 14, 2021 07:24
@snario snario requested a review from tynes June 16, 2021 16:45
@smartcontracts
Copy link
Contributor

Going to close this PR. We haven't had any movement on it for a while and we're likely going to need to completely redo it against the experimental branch.

@gakonst gakonst deleted the gakonst/remove-miner-2 branch September 29, 2021 06:12
@gakonst
Copy link
Contributor Author

gakonst commented Sep 29, 2021

SGTM. Apologies for not being able to get it over the line at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants