Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The OVM tutorial link in Readme.md is broken. #386

Closed
john-a-m opened this issue Jan 5, 2021 · 2 comments · Fixed by #398
Closed

The OVM tutorial link in Readme.md is broken. #386

john-a-m opened this issue Jan 5, 2021 · 2 comments · Fixed by #398

Comments

@john-a-m
Copy link

john-a-m commented Jan 5, 2021

It points to https://github.com/ethereum-optimism/ERC20-Example , which doesn't appear to exist anymore. Similarly there is a broken link on https://docs.optimism.io/developer-documentation/erc20-tutorial that points to https://github.com/ethereum-optimism/optimism-monorepo/tree/master/packages/examples .
@atnjqt
Copy link

atnjqt commented Jan 15, 2021

Yes I am also wondering about the last section of README, regarding docker composer... there is no Dockerfile or docker-compose.yml example given!

honestly not sure what running the 'fullnode' on docker accomplishes but still interesting

@tynes
Copy link
Contributor

tynes commented Jan 15, 2021

Please see the updated example: https://github.com/ethereum-optimism/optimism-tutorial

ianaz added a commit to ianaz/optimism-monorepo that referenced this issue Jan 31, 2021
@ianaz
Fix tutorial link (ethereum-optimism#386)
ad8eeb7 
Fixes non-existing (404) tutorial link to the new repository
@ianaz ianaz mentioned this issue Jan 31, 2021
Merged
1 task
@tynes tynes closed this as completed in #398 Feb 2, 2021
tynes pushed a commit that referenced this issue Feb 2, 2021
@ianaz
Fix tutorial link (#386) (#398)
af65889 
Fixes non-existing (404) tutorial link to the new repository
protolambda added a commit to protolambda/optimism that referenced this issue May 1, 2022
@protolambda
Merge pull request ethereum-optimism#386 from ethereum-optimism/jg/fi…
31d9a92 
…x_tob_6

opnode: Fix L1 Info Transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tutorial link (#386) ianaz/optimism-monorepo
3 participants
@john-a-m @tynes @atnjqt